Repository navigation
Commit 9ece365
authored
Revert: Reland square corners fix (flutter#195436)
Reverts: [Reland square corners
fix](flutter#194314)
Initiated by: @andywolff
Reason for reverting: changed opacity behavior causing golden flakes
flutter#195423
Original PR Author: @andywolff
Reviewed By: @gaaclarke
The original PR description is provided below:
Fixes flutter#192992
Relands flutter#191096
Fixes flutter#190602
Fixes flutter#162172
This PR relands flutter#191096, which
resolves the square corners regression in clipped backdrop filters. The
original PR was reverted in
flutter#193189 due to test flakiness and
order dependencies in CI, which were resolved and landed separately in
flutter#193497.
This is a pure reland.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md1 parent df89551 commit 9ece365
10 files changed
Lines changed: 42 additions & 342 deletions
File tree
- engine/src/flutter/impeller
- display_list
- entity
- contents
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
207 | 206 | | |
208 | 207 | | |
209 | 208 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | 12 | | |
15 | 13 | | |
16 | 14 | | |
| |||
141 | 139 | | |
142 | 140 | | |
143 | 141 | | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | 142 | | |
220 | 143 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1780 | 1780 | | |
1781 | 1781 | | |
1782 | 1782 | | |
1783 | | - | |
1784 | | - | |
| 1783 | + | |
1785 | 1784 | | |
| 1785 | + | |
| 1786 | + | |
| 1787 | + | |
1786 | 1788 | | |
1787 | 1789 | | |
1788 | 1790 | | |
| |||
1945 | 1947 | | |
1946 | 1948 | | |
1947 | 1949 | | |
1948 | | - | |
| 1950 | + | |
1949 | 1951 | | |
1950 | 1952 | | |
1951 | 1953 | | |
| |||
2031 | 2033 | | |
2032 | 2034 | | |
2033 | 2035 | | |
2034 | | - | |
2035 | | - | |
| 2036 | + | |
| 2037 | + | |
| 2038 | + | |
| 2039 | + | |
2036 | 2040 | | |
2037 | 2041 | | |
2038 | 2042 | | |
| |||
2077 | 2081 | | |
2078 | 2082 | | |
2079 | 2083 | | |
2080 | | - | |
2081 | | - | |
2082 | | - | |
2083 | | - | |
2084 | | - | |
2085 | | - | |
2086 | | - | |
2087 | | - | |
2088 | | - | |
2089 | | - | |
| 2084 | + | |
| 2085 | + | |
| 2086 | + | |
2090 | 2087 | | |
2091 | 2088 | | |
2092 | 2089 | | |
| |||
2648 | 2645 | | |
2649 | 2646 | | |
2650 | 2647 | | |
| 2648 | + | |
| 2649 | + | |
2651 | 2650 | | |
2652 | 2651 | | |
2653 | 2652 | | |
| |||
2659 | 2658 | | |
2660 | 2659 | | |
2661 | 2660 | | |
2662 | | - | |
| 2661 | + | |
2663 | 2662 | | |
2664 | 2663 | | |
2665 | 2664 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
125 | | - | |
126 | | - | |
| 124 | + | |
127 | 125 | | |
128 | 126 | | |
129 | 127 | | |
| |||
0 commit comments