Fixed #1317: Regression coming from ArtifactVersions::filter when currentVersion is null and ignoredVersions is not null#1319
Merged
andrzejj0 merged 1 commit intomojohaus:masterfrom Nov 30, 2025
Conversation
…when currentVersion is null and ignoredVersions is not null
slawekjaranowski
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is caused by a refactoring job of RuleService using the new ArtifactVersions::filter, which causes IgnoreVersionHelper to trigger an NPE.
Fixed both the root cause (testing against a non-existing version) as well as the susceptibility of the IgnoreVersionHelper to trigger an NPE if the version is null.