Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotless and markdown #504

Closed
slawekjaranowski opened this issue May 12, 2024 · 3 comments · Fixed by #505
Closed

spotless and markdown #504

slawekjaranowski opened this issue May 12, 2024 · 3 comments · Fixed by #505
Labels
bug

Comments

@slawekjaranowski
Copy link
Member

We need check only project markdown files.
Generated files from target should be excluded.

Reproduce, eg in tidy-maven-plugin execute site build twice:

mvn site

mvn site

we have:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project tidy-maven-plugin: failed to get report for org.apache.maven.plugins:maven-plugin-report-plugin: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.43.0:check (spotless-check) on project tidy-maven-plugin: The following files had format violations:
[ERROR]     target/site/apidocs/legal/jquery.md
[ERROR]         @@ -1,6 +1,7 @@
[ERROR]          ##·jQuery·v3.6.1
[ERROR]          
[ERROR]          ###·jQuery·License
[ERROR]         +
[ERROR]          ```
....
@slawekjaranowski
Copy link
Member Author

@slachiewicz can you look 😄

@slachiewicz
Copy link
Member

https://github.com/mojohaus/mojo-parent/blob/31f1276f1d5a750be596befcaa379a356ec278f9/pom.xml#L599C13-L604C24

include:
.md
src/site/markdown/**/.md

@slawekjaranowski
Copy link
Member Author

maybe:

                <include>*.md</include>
                <include>src/**/.md</include>

slawekjaranowski added a commit that referenced this issue May 13, 2024
@slawekjaranowski
Fix spotless configuration for markdown - exclude generated files
a233401 
fix #504
@slawekjaranowski slawekjaranowski mentioned this issue May 13, 2024
Merged
slawekjaranowski added a commit that referenced this issue May 13, 2024
@slawekjaranowski
Fix spotless configuration for markdown - exclude generated files
98619db 
fix #504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spotless configuration for markdown - exclude generated files mojohaus/mojo-parent
2 participants
@slawekjaranowski @slachiewicz