Skip to content

Fix issue #13448 - Enhance duplicate dialog#13475

Merged
alroniks merged 1 commit intomodxcms:2.xfrom
lawrenz1337:fix-issue-13448
Jul 7, 2017
Merged

Fix issue #13448 - Enhance duplicate dialog#13475
alroniks merged 1 commit intomodxcms:2.xfrom
lawrenz1337:fix-issue-13448

Conversation

@lawrenz1337
Copy link
Copy Markdown
Contributor

What does it do?

It shows the pagetitle and ID of the resource in the 'Duplicate' dialog

Why is it needed?

The default UI for 'Duplicate' dialog doesn't show the name and ID and it is pretty easy to forget which reource you are trying to duplicate.

Related issue(s)/PR(s)

Issue #13448

@rtripault rtripault added this to the v2.6.0 milestone Jun 22, 2017
@lawrenz1337 lawrenz1337 changed the title Fix #13448 - Enhance duplicate dialog Fix issue #13448 - Enhance duplicate dialog Jun 22, 2017
@Mark-H
Copy link
Copy Markdown
Collaborator

Mark-H commented Jun 26, 2017

Hey @lawrenz1337, thanks for your contribution. Have you submitted the CLA for MODX before? That can be found here: https://develop.modx.com/contribute/cla/

@lawrenz1337
Copy link
Copy Markdown
Contributor Author

lawrenz1337 commented Jun 26, 2017

@Mark-H No I haven't, I will do it right now.
EDIT: Done, I've submitted the CLA.

@wuuti
Copy link
Copy Markdown
Contributor

wuuti commented Jul 7, 2017

can this be reviewed and merged during the 2nd modxbughunt?

@alroniks
Copy link
Copy Markdown
Contributor

alroniks commented Jul 7, 2017

@wuuti I'll check it today

@alroniks alroniks self-assigned this Jul 7, 2017
@alroniks alroniks merged commit 53df0c5 into modxcms:2.x Jul 7, 2017
@lawrenz1337 lawrenz1337 deleted the fix-issue-13448 branch July 7, 2017 10:55
@alroniks
Copy link
Copy Markdown
Contributor

alroniks commented Jul 7, 2017

#modxbughunt

@gpsietzema
Copy link
Copy Markdown
Contributor

#modxbughunt #1point to @alroniks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants