fix: correct default order status IDs and add fallback for zero values#91
Merged
fix: correct default order status IDs and add fallback for zero values#91
Conversation
System settings ms3_status_new, ms3_status_paid, ms3_status_canceled had default value 0, causing "Status not found" error on order submit. Fixed defaults to match seeded statuses (new:2, paid:3, canceled:5) and added ?: fallback in all getOption calls to handle existing installations where settings are already saved with value 0. Fixes #89 Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ms3_status_new(0→2),ms3_status_paid(0→3),ms3_status_canceled(0→5) in_build/elements/settings.php?: defaultfallback in all 11getOption('ms3_status_*')calls across 7 files to handle existing installations where settings are saved with value 0Root cause
$modx->getOption('ms3_status_new', null, 2)returns0(not the fallback2) when the setting exists with value0. This causedOrderStatusService::change()to fail with "Status not found" error on order submit.Fixes #89
🤖 Generated with Claude Code