fix: add class_key to getIterator for msProduct/msCategory (#87)#90
Merged
fix: add class_key to getIterator for msProduct/msCategory (#87)#90
Conversation
xPDO::getIterator() does not call addDerivativeCriteria(), unlike getCollection(). For classes without their own table (msProduct, msCategory extend modResource), this causes wrong class instantiation. Added explicit class_key criteria to all affected getIterator calls: - CategoryProductsController::getChildCategories() - CategoryProductsController::getList() - ReferencesController::searchProducts() - Settings\Option\Get::beforeOutput() Fixes #87 Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xPDO::getIterator()does not calladdDerivativeCriteria(), unlikegetCollection()class_keyfilter to all affectedgetIteratorcallsAffected files:
CategoryProductsController::getChildCategories()— root cause of the bugCategoryProductsController::getList()— defense-in-depthReferencesController::searchProducts()— real riskSettings\Option\Get::beforeOutput()— defense-in-depthFixes #87
Test plan
🤖 Generated with Claude Code