fix: приведение типов для extra fields в msProductData#170
Merged
Conversation
…Data Пустая строка из формы для decimal/int/tinyint колонок вызывала MySQL ошибку "Incorrect decimal value", из-за чего save() возвращал false и категории/опции/ссылки молча не сохранялись. Заменяет хардкод каста price/old_price/weight на универсальный цикл по _fieldMeta, покрывающий все поля включая Extra Fields.
- Исключаем id из итерации чтобы не помечать его dirty (AUTO_INCREMENT) - Выносим get() перед ветвлением по типу - Обновляем docblock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wholesale_price) пустая строка из формы вызывала MySQL ошибкуIncorrect decimal value: '' for columnmsProductData::save()возвращалfalse, иsaveCategories()/saveOptions()/saveLinks()молча не выполнялись — пользователь терял дополнительные категории без какой-либо ошибки в UIprice/old_price/weightна универсальный цикл по_fieldMeta, покрывающий все поля включая Extra Fields (float,integer,boolean)Test plan
decimal(напримерwholesale_price)price,old_price,weight) по-прежнему корректно кастятся🤖 Generated with Claude Code