refactor: migrate product gallery from ExtJS to Vue#150
Merged
Conversation
Replace ExtJS gallery panel (panel, toolbar, view, window, ddview) with pure Vue components: ProductGallery, ProductGalleryGrid, ProductGalleryToolbar, ProductGalleryEditDialog. - Add useGalleryApi composable for all gallery API calls - Add UpdateSource processor for changing media source - Embed GalleryUploader (Uppy) into product-tabs bundle - Remove gallery-uploader separate entry point - Add ConfirmationService to product-tabs - Add PrimeVue ContextMenu for file actions - Extend Uppy locale strings (back, dropHint, error, etc.) - Add new lexicon keys for gallery search and empty state - Remove ExtJS gallery CSS from main.css - Add .uppy- prefix to PostCSS exclude list
- Fix unhandled promise in onChangeSource (add async/await + try/catch) - Pass allowedFileTypes, maxWidth, maxHeight from media source config to GalleryUploader (prevents regression for custom media sources) - Fix drag-drop UX: use local ref + watch instead of read-only computed so vuedraggable can mutate array for instant visual reorder - Change pageSize from 20 to 50 (matches old ExtJS behavior) - Sort media sources list by name in controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #112
ProductGallery→ProductGalleryGrid+ProductGalleryToolbar+GalleryUploader+ProductGalleryEditDialoguseGalleryApicomposable for all gallery API calls (connector direct, not REST API)UpdateSourceprocessor for changing product media sourcegallery-uploaderentry point — Uppy now bundled intoproduct-tabsWhat changed
Created
useGalleryApi.jsProductGallery.vueProductGalleryGrid.vueProductGalleryToolbar.vueProductGalleryEditDialog.vueUpdateSource.phpModified
ProductTabs.vuetype: 'extjs'→type: 'vue', removed ExtJS gallery init codeproduct-tabs.jsConfirmationServiceGalleryUploader.vuedefineExpose, addedwatchon sourceId, extended Uppy localeupdate.class.phpsourcesto configvite.config.jsgallery-uploaderentry, added.uppy-to PostCSS excludemain.cssDeleted (6 files)
gallery.panel.js,gallery.toolbar.js,gallery.view.js,gallery.window.jsext.ddview.js,gallery-uploader.jsentryTest plan
🤖 Generated with Claude Code