fix: absolute URLs in customer orders filter and pagination#141
Merged
Conversation
Relative URLs ('?', '?offset=...') resolved against <base href> tag
to site root instead of current page, breaking the reset button
and pagination links on customer order history page.
…iendly_urls Build pagination URLs via makeUrl() with http_build_query() instead of string concatenation in the template. This preserves the active status filter across pages and produces valid URLs when friendly_urls is disabled (avoids index.php?id=15?offset=20).
Add icon-arrow-left, icon-truck, icon-credit-card, icon-message symbols to customer.tpl sprite sheet. Fix fill="currentColor" to fill="none" stroke="currentColor" for Feather stroke-based icons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/?) вместо текущей страницы — из-за<base href>тега в шаблоне MODX?offset=...резолвились от корняpage_url(абсолютный URL черезmakeUrl) вOrdersPageService, используется в чанке для form action, кнопки сброса и пагинацииTest plan
/zakazyi-klienta.html?status=2/zakazyi-klienta.html(не на/)/zakazyi-klienta.html?offset=...🤖 Generated with Claude Code