fix: display order status in customer order history#139
Merged
Conversation
- Extract loadStatusData() to eliminate code duplication - Replace broken LEFT JOIN ad-hoc fields with batch loading for both order statuses and product data (pagetitle, article, old_price) - Add empty color guard in status badge chunks
biz87
force-pushed
the
fix/order-status-display
branch
from
d39b361 to
c528773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LEFT JOINcolumns (status_name,status_color) не гидрировались в xPDO-объекты, т.к.fromArray()пропускает ad-hoc поля (hydrate_adhoc_fieldsне включён). Заменён JOIN на предзагрузку статусов в map с маппингом поstatus_id#(например008000), что делалоbackground-color: 008000невалидным CSS. Добавлен#в обоих чанках (ms3_customer_order_row.tpl,ms3_customer_order_details.tpl)Test plan
🤖 Generated with Claude Code