fix: add MODX table prefix to relation field table names#136
Merged
Conversation
When users configure relation fields via grid config utility with direct table names (e.g. ms3_orders), the MODX table prefix was not applied. This caused SQL queries in fetchRelationData() to reference non-existent tables, silently returning zeros for all aggregate values. Fix applied in two places: - GridConfigService::validateRelationConfig() — prefix added on save - CustomersController::fetchRelationData() — fallback for existing configs
Review fix: getTableName() returns backtick-quoted names like `modx_ms3_orders`. The fallback prefix check in fetchRelationData() incorrectly added prefix to already-resolved names because strpos missed the leading backtick. Now skips prefixing for backtick-quoted names. Also: strpos → str_starts_with (PHP 8.2+), marked fallback as temporary with removal guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orders_countwithCOUNT()onms3_orders) returned zeros because the MODX table prefix was not applied to direct table namesGridConfigService::validateRelationConfig()now adds the table prefix when saving relation config with a direct table nameCustomersController::fetchRelationData()adds a fallback prefix check for configs already saved without prefixTest plan
ms3_orders)modx_, empty)