fix: allow clearing EAV options from product form#101
Merged
Conversation
Remove array_filter in Product/Create and Product/Update processors that was stripping empty option values before they reached the service layer. Add removeOptionKey() to OptionSyncService so empty values signal deletion of the option from ms3_product_options table. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array_filterв процессорахProduct/CreateиProduct/Update, который отбрасывал пустые значения опций до передачи в сервисremoveOptionKey()вOptionSyncService— пустое значение опции теперь сигнализирует об удалении записи изms3_product_optionsПроблема: при очистке EAV-опции на вкладке "Опции" в админке значение не удалялось из БД, а оставалось старым.
Test plan
ms3_product_options🤖 Generated with Claude Code