fix: daemon autostart for prebuilt npm binaries#84
Merged
benvinegar merged 2 commits intomainfrom Mar 23, 2026
Merged
Conversation
Bun-compiled single-file executables set process.execPath to the embedded Bun runtime, not the binary itself. When the daemon launcher tried to spawn `process.execPath mcp serve`, it was invoking bare Bun with invalid args instead of the prebuilt hunk binary. Fix: when argv[0] differs from execPath, use argv[0] as the command — that's the actual compiled binary the user invoked. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
benvinegar
added a commit
that referenced
this pull request
Mar 23, 2026
The previous fix (PR #84) assumed argv[0] was the real binary and execPath was the embedded Bun runtime, but it's the opposite: Bun compiled binaries report argv as ["bun", "/$bunfs/root/<name>", ...] with execPath pointing to the real binary on disk. The old code matched the $bunfs virtual path against SCRIPT_ENTRYPOINT_PATTERN (because it contains "/"), spawning `bun /$bunfs/root/hunk mcp serve` — a path that doesn't exist outside the binary. Fix: detect the /$bunfs/ prefix in argv[1] and use execPath directly. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
4 tasks
benvinegar
added a commit
that referenced
this pull request
Mar 23, 2026
…#86) * fix: detect $bunfs virtual paths for daemon autostart in Bun binaries The previous fix (PR #84) assumed argv[0] was the real binary and execPath was the embedded Bun runtime, but it's the opposite: Bun compiled binaries report argv as ["bun", "/$bunfs/root/<name>", ...] with execPath pointing to the real binary on disk. The old code matched the $bunfs virtual path against SCRIPT_ENTRYPOINT_PATTERN (because it contains "/"), spawning `bun /$bunfs/root/hunk mcp serve` — a path that doesn't exist outside the binary. Fix: detect the /$bunfs/ prefix in argv[1] and use execPath directly. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * style: format daemon launcher test Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> --------- Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.execPathto the embedded Bun runtime, not the binary itself.launchHunkDaemon()was spawning bare Bun with["mcp", "serve"]— an invalid commandargv[0]differs fromexecPath, useargv[0]as the spawn command since that's the actual compiled binaryTest plan
npm i -g hunkdiff, kill any daemon, runhunk show— daemon should auto-start andhunk session listshould find it🤖 Generated with Claude Code