perf: benchmark and optimize large split review streams#76
Merged
benvinegar merged 9 commits intomainfrom Mar 23, 2026
Merged
Conversation
…h before optimization; current 18-tick note-enabled scroll cost is 16406.23ms and still shows act warnings from deferred highlight work.\n\nResult: {"status":"keep","note_scroll_ticks_ms":16406.23}
…indowing active for the rest of the review stream; note-enabled 18-tick scroll drops from 16406.23ms to 647.48ms while the interaction test now follows notes as focus moves.\n\nResult: {"status":"keep","note_scroll_ticks_ms":647.48}
…holder windowing keeps accurate heights for the selected note-bearing file; note-enabled 18-tick scroll drops from 647.48ms to 231.25ms and the section-height helper now has note-row coverage.\n\nResult: {"status":"keep","note_scroll_ticks_ms":231.25}
…note-enabled 18-tick scroll improves further to 197.32ms, though the benchmark still occasionally surfaces deferred Pierre highlight act warnings that should be cleaned up separately.\n\nResult: {"status":"keep","note_scroll_ticks_ms":197.32}
…lected-hunk-only notes; under the broader visible-note policy the current 18-tick large-stream scroll cost is 2009.15ms.\n\nResult: {"status":"keep","note_scroll_ticks_ms":2009.15}
…ed visible notes reuse placeholder height plans across scroll ticks; under the restored always-visible note policy, the 18-tick large-stream scroll cost drops from 2009.15ms to 301.54ms while viewport-visible notes stay on screen.\n\nResult: {"status":"keep","note_scroll_ticks_ms":301.54}
benvinegar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmarks/and document the benchmark workflowCurrent behavior and findings
Measured results
Original note-enabled baseline
Selected-hunk-only experiment (discarded product direction)
Restored viewport-scoped-visible-notes baseline
Current kept result under viewport-scoped note visibility
Stage-profile sample
Main implementation changes
benchmarks/benchmarks/results/locationDeferred ideas
DiffPanewith an event-driven scrollbox hook if OpenTUI exposes onebuildReviewRenderPlan()rebuildsTesting