Conversation
Greptile SummaryThis PR fixes two visual alignment bugs in the inline AI note rendering: it removes the extraneous blank spacer row that was appended below split-layout note cards, and it corrects column alignment by moving the note guide Key changes:
Confidence Score: 5/5Safe to merge — the fix is logically consistent across all rendering paths and is well-covered by regression tests. All three changed files are correct: the height formula and JSX removal in AgentInlineNote are exact inverses of the old spacer logic; the column-budget arithmetic in renderRows is self-consistent (left swap is width-neutral, right reduction matches the appended span); and the tests assert both the blank-row removal and the column-alignment property directly. No P0/P1 findings identified. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant RRP as reviewRenderPlan
participant PIV as PierreDiffView
participant AIN as AgentInlineNote
participant DRV as DiffRowView / renderRow
RRP->>PIV: PlannedReviewRow[] (inline-note, diff-row w/ noteGuideSide, note-guide-cap)
PIV->>AIN: kind="inline-note" → renders note card (height = 3 + lines.length)
Note over AIN: No trailing blank connector row (removed)
PIV->>DRV: kind="diff-row", noteGuideSide="new"|"old"
alt guideOnNewSide
DRV->>DRV: rightRenderWidth = rightWidth - 1
DRV->>DRV: append │ span at column width-1
else guideOnOldSide
DRV->>DRV: leftPrefix.text = "│" (replaces marker, same width)
end
PIV->>PIV: kind="note-guide-cap" → AgentInlineNoteGuideCap (╵ at col 0 or width-1)
Reviews (1): Last reviewed commit: "fix: align inline note rendering" | Re-trigger Greptile |
Summary
Testing
bun run typecheckbun testbun run test:tty-smokeThis PR description was generated by Pi using OpenAI GPT-5