Greptile Summary

This PR fixes a long-standing layout bug in the keyboard help dialog where shortcut rows would overlap each other due to an incorrect height calculation (+ 3 for chrome overhead was far too small). The fix correctly computes contentRowCount from the actual section/item data, adds a named modalFrameChromeRowCount constant, and gracefully degrades to a <scrollbox> fallback when the terminal is too short to fit the full dialog. A targeted regression test is added that both proves the fix and guards against future reintroductions of the overlap.

Key changes:

• contentRowCount is now derived from the sections data structure rather than inlined into the height formula
• modalFrameChromeRowCount = 6 replaces the old hardcoded + 3, though the actual chrome visible in ModalFrame's JSX counts to 5 rows — worth verifying
• A conditional <scrollbox focused={false}> wrapper is applied when shouldScroll is true, consistent with the PierreDiffView pattern elsewhere in the codebase
• Each section title and each item row now have an explicit height: 1 on their wrapping boxes, which is what prevents the overlap at the layout level
• The regression test uses overlap-detection strings ("linese/Awrapt/smetadata") to assert that adjacent rows have not been concatenated by the renderer

Confidence Score: 5/5

• Safe to merge; the primary bug is fixed, the approach matches existing codebase patterns, and a regression test guards the fix.
• The root cause (chrome rows undercounted as 3 instead of ~5-6) is clearly identified and fixed. The height: 1 annotations on each row box address the layout-level overlap. The scroll fallback uses the same focused={false} scrollbox pattern already established in PierreDiffView. The only open question — whether modalFrameChromeRowCount should be 5 rather than 6 — has at most a 1-row cosmetic impact on dialog sizing and does not cause content overlap or data loss.
• No files require special attention; the potential off-by-one in modalFrameChromeRowCount in HelpDialog.tsx is worth a quick sanity-check but is non-blocking.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["HelpDialog renders"] --> B["Compute contentRowCount\n(sections × title + items)"]
    B --> C["requiredModalHeight =\ncontentRowCount + modalFrameChromeRowCount(6)"]
    C --> D["modalHeight = min(requiredModalHeight,\nmax(8, terminalHeight − 2))"]
    D --> E{"shouldScroll?\nmodalHeight < requiredModalHeight"}
    E -- "No (terminal large enough)" --> F["Render content directly\ninside ModalFrame"]
    E -- "Yes (terminal too short)" --> G["Wrap content in\nscrollbox focused=false"]
    F --> H["ModalFrame with height=modalHeight"]
    G --> H

_{Reviews (1): Last reviewed commit: "fix keyboard help overlay overlap" | Re-trigger Greptile}