Skip to content

Dag bruck patch modelica#37

Merged
pmai merged 4 commits intomainfrom
DagBruck-patch-modelica
Sep 13, 2024
Merged

Dag bruck patch modelica#37
pmai merged 4 commits intomainfrom
DagBruck-patch-modelica

Conversation

@DagBruck
Copy link
Copy Markdown
Contributor

@DagBruck DagBruck commented Jun 9, 2024

Revised proposal for Modelica support in SSP. The significant changes are:

  • Added the connector kind "acausal", allowing one acausal connector to connected to another,
  • Added MIME-type "text/x-modelica" which has an additional attribute "path" which designates the Modelica class.

Compared to the previous proposal which was withdrawn:

  • No source attribute for Binary types (replaced by attribute in MIME-type).
  • No "rotational" attribute for connectors.

@DagBruck DagBruck added the enhancement New feature or request label Jun 9, 2024
@DagBruck DagBruck added this to the 2.0-alpha.1 milestone Jun 9, 2024
@pmai
Copy link
Copy Markdown
Collaborator

pmai commented Jun 13, 2024

F2F 2024-06-13: Decision to include modelica-specific parts in the core standard, as the modelica-specific text is
a) fairly small
b) fairly stable (e.g. RealInput/etc. to Real/input mapping is at least as stable if not more so than FMI mappings)
c) Modelica is a core standard of the MA, the same as FMI.

DagBruck added 2 commits July 5, 2024 09:30
Added some text to described how Modelica components and connectors
should be mapped to SSP. Add rotation attribute to connectors.
Revised specification of Modelica support, specifically
- Modelica class specified via MIME-type attribute "path".
- No "source" attribute for binary types added.
- Graphical attribute "rotation" not added.
@pmai pmai force-pushed the DagBruck-patch-modelica branch from 4a49fc7 to 3d4e659 Compare July 5, 2024 07:52
@pmai
Copy link
Copy Markdown
Collaborator

pmai commented Jul 5, 2024

The issue whether to still allow/point out the use of a particular URI scheme like 'modelica:' in the source of a Modelica component to locate it and also to indicate that it the component has an implementation and is not abstract shall be discussed in the meeting that discusses merge of this PR once it is finalized.

@JochenKoehler
Copy link
Copy Markdown
Collaborator

web meeting 2024-08-13:
Ulrich will do a review on this

Copy link
Copy Markdown

@UKiffmeier UKiffmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review successful. Only one minor comment regarding highlighting of technical terms (line 559)

@pmai
Copy link
Copy Markdown
Collaborator

pmai commented Sep 13, 2024

CCB 2024-09-13: Can be merged as-is after final confirmation by @UKiffmeier that the schema changes are correct.

Copy link
Copy Markdown

@UKiffmeier UKiffmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review successful. PR can be completed.

@pmai pmai merged commit da838ec into main Sep 13, 2024
@pmai pmai self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants