Use annotations to mark configuration variables#69
Closed
t-sommer wants to merge 2 commits intomodelica:mainfrom
Closed
Use annotations to mark configuration variables#69t-sommer wants to merge 2 commits intomodelica:mainfrom
t-sommer wants to merge 2 commits intomodelica:mainfrom
Conversation
Collaborator
|
I think if we are going to refactor the LS-XCP, due to also the missing ability to support more than one A2L file/XCP slave, then I think the better alternative would be to just name the variables in the manifest file of the ls-xcp, which, if we go down the route of not having fixed names, seems preferable, as it is more self-contained. It would also allow for grouping, so that we can have a wrapper element, which makes support for multiple A2L files and multiple XCP slaves simpler: e.g.: <?xml version="1.0" encoding="UTF-8"?>
<fmiLayeredStandardManifest
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../schema/fmi3LayeredStandardXcpManifest.xsd"
xmlns:fmi-ls="http://fmi-standard.org/fmi-ls-manifest"
fmi-ls:fmi-ls-name="org.fmi-standard.fmi-ls-xcp"
fmi-ls:fmi-ls-version="1.0.0-rc.4"
fmi-ls:fmi-ls-description="Layered standard based on FMI 2.0 and FMI 3.0 for describing and implementing XCP support for FMUs, which can either provide an XCP service or allow direct memory access via A2L files.">
<access identifier="foo"
containsXcpService="true"
supportsDirectMemoryAccessViaA2L="true"
EnableXcpOnTcpIpVariable="top.EnableXcpOnTcpIp"
EnableXcpOnUdpIpVariable="top.EnableXcpOnUdpIp"
TcpListenIpAddressVariable="top.TcpListenIpAddress"
TcpListenPortNumberVariable="top.TcpListenPortNumber"
UdpListenIpAddressVariable="top.UdpListenIpAddress"
UdpListenPortNumberVariable="top.UdpListenPortNumber"/>
<access identifier="bar"
containsXcpService="true"
supportsDirectMemoryAccessViaA2L="false"
EnableXcpOnTcpIpVariable="org.fmi_standard.fmi_ls_xcp.EnableXcpOnTcpIp"
TcpListenPortNumberVariable="org.fmi_standard.fmi_ls_xcp.TcpListenPortNumber"/>
</fmiLayeredStandardManifest>I've prepared a PR which sketches this approach out. |
bmenne-dspace
approved these changes
Jun 18, 2024
Collaborator
|
Pierre will close this in favour of #76 |
pmai
added a commit
that referenced
this pull request
Jun 18, 2024
pmai
added a commit
that referenced
this pull request
Jun 19, 2024
pmai
added a commit
that referenced
this pull request
Jun 19, 2024
pmai
added a commit
that referenced
this pull request
Aug 13, 2024
* Initial sketch of manifest-based naming and multi A2L (fixes #63). * Add documentation for manifest-based variable naming * Regularize naming of attributes (fixes #68, #78, #79). * Incorporate formatting changes from #69 by @t-sommer. * Broader refactoring of manifest mechanism and naming (fixes #80). * Add ability to restrict Interface to certain CS/ME/SE (fixes #83). * Validate examples in CI * Use curly braces for protocol alternatives * Extend description of "types" attribute * Fix role attribute for XCP.vECU1.UDP.* variables * Fix list * Some small formal changes * Adjust wording and add IPv6 addresses Signed-off-by: Pierre R. Mai <[email protected]> Co-authored-by: Torsten Sommer <[email protected]> Co-authored-by: Patrick Taeuber <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #64