Skip to content

(fix): Update fallbackRequestHandler type to match _requestHandlers leaves type#784

Merged
ihrpr merged 1 commit intomodelcontextprotocol:mainfrom
fredericbarthelet:fix-type-fallbackRequestHandler
Jul 29, 2025
Merged

(fix): Update fallbackRequestHandler type to match _requestHandlers leaves type#784
ihrpr merged 1 commit intomodelcontextprotocol:mainfrom
fredericbarthelet:fix-type-fallbackRequestHandler

Conversation

@fredericbarthelet
Copy link
Copy Markdown
Contributor

@fredericbarthelet fredericbarthelet commented Jul 18, 2025 •
edited
Loading

This PR only updates type definition

fallbackRequestHandler current type is not matching the type of what it is a fallback for, i.e. the type of each request handler on the Server.

The following code snippet is the only location where fallbackRequestHandler is used

typescript-sdk/src/shared/protocol.ts

Lines 367 to 368 in 0d54517

const handler =
this._requestHandlers.get(request.method) ?? this.fallbackRequestHandler;

Motivation and Context

fallbackRequestHandler current type lacks the request id, the jsonrpc version (while being actually forwarded) and the extra param altogether. Updating the type avoid having the rely on type casting where fallback must be defined. The new type is exacly the one defined for _requestHandlers leaves:

typescript-sdk/src/shared/protocol.ts

Lines 182 to 188 in 0d54517

private _requestHandlers: Map<
string,
(
request: JSONRPCRequest,
extra: RequestHandlerExtra<SendRequestT, SendNotificationT>,
) => Promise<SendResultT>
> = new Map();

How Has This Been Tested?

Locally on my project

Breaking Changes

Non breaking, JSONRPCRequest is actually narrower than Request

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@fredericbarthelet fredericbarthelet requested review from a team and ihrpr July 18, 2025 19:56
@fredericbarthelet
Copy link
Copy Markdown
Contributor Author

fredericbarthelet commented Jul 29, 2025

Hey @ihrpr, sorry for the ping.
Any chance you or someone from your team can have a look at this :)?
Thanks for your help 🙏

ihrpr
ihrpr approved these changes Jul 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredericbarthelet Sorry, this PR completely fell off my radar! Thank you for the fix

NOTE: this is breaking changes, as fallbackRequestHandler adds extra parameter as well

@ihrpr ihrpr merged commit ee16173 into modelcontextprotocol:main Jul 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihrpr ihrpr ihrpr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fredericbarthelet @ihrpr