fix: prevent ReDoS in UriTemplate regex patterns (v1.x backport) #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exploded array handling regex patterns were vulnerable to ReDoS attacks. Changed [^/]+ to [^/,]+ in the character class to prevent catastrophic backtracking. CVE-2026-0621 Fixes #965
|
commit: |
1 task
Member
Author
|
hmm changesets don't exist on the v1.x branch, we should probably fix that notification |
bhosmer-ant
approved these changes
Jan 7, 2026
joeyorlando
added a commit
to archestra-ai/archestra
that referenced
this pull request
Jan 7, 2026
See modelcontextprotocol/typescript-sdk#1365 Closes https://github.com/archestra-ai/archestra/security/dependabot/70 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > <sup>[Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) is generating a summary for commit dc193e5. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport of the ReDoS fix from #1363 to the v1.x branch.
Changes
The exploded array handling regex patterns in
UriTemplatewere vulnerable to ReDoS (Regular Expression Denial of Service) attacks. Changed[^/]+to[^/,]+in the character class to prevent catastrophic backtracking when matching malicious input.Security Impact
Changes Made
Testing
All existing tests pass, plus two new security regression tests that verify the fix prevents the ReDoS vulnerability.
Version
Bumped to v1.25.2 for patch release.
Fixes #965