Upgrade to Node LTS#1072
Merged
felixweinberger merged 8 commits intomodelcontextprotocol:mainfrom Nov 7, 2025
Merged
Conversation
felixweinberger
requested changes
Nov 4, 2025
package.json
Outdated
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=18", | ||
| "npm": ">=10" |
Contributor
There was a problem hiding this comment.
Is the NPM upgrade intentional? Apparently node 18 ships with older npm versions, might be an inadvertently breaking change?
Contributor
Author
There was a problem hiding this comment.
I thought it shipped with 10+ but yep I'm wrong. Will remove:
{
"version": "v18.0.0",
"date": "2022-04-18",
"files": [
"aix-ppc64",
"headers",
"linux-arm64",
"linux-armv7l",
"linux-ppc64le",
"linux-s390x",
"linux-x64",
"osx-arm64-tar",
"osx-x64-pkg",
"osx-x64-tar",
"src",
"win-x64-7z",
"win-x64-exe",
"win-x64-msi",
"win-x64-zip"
],
"npm": "8.6.0",
"v8": "10.1.124.8",
"uv": "1.43.0",
"zlib": "1.2.11",
"openssl": "3.0.2+quic",
"modules": "108",
"lts": false,
"security": false
},
mattzcarey
commented
Nov 4, 2025
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates node from 18 to current LTS (24) in Github CI as it is entering EOL in the new year.
Tests against both the oldest legacy version we should support until April (18) and current LTS (24).
I would strongly suggest we upgrade our oldest version to 22 soon.
Motivation and Context
How Has This Been Tested?
Tests test against both versions. We just build in the newer version so we can use tsdown. #1071
Breaking Changes
No
Types of changes
Checklist
Additional context