Repository navigation
v2: Refactor task-related properties and improve type definitions #1275
Description
Summary
Refactoring opportunities for the v2 implementation related to task properties and TypeScript type definitions.
Motivation and Context
The current implementation has some patterns that could be improved for better code organization and type safety.
Proposed Changes
1. Group task-related properties
Currently there are multiple taskX variables at the same level:
taskId?: string;
taskStore?: RequestTaskStore;
taskRequestedTtl?: number | null;Consider grouping these under a single task object:
task?: {
id: string;
store: RequestTaskStore;
requestedTtl: number | null;
};This provides better organization and makes it clearer these properties are related.
2. Distinguish between optional properties and undefined values
In TypeScript:
// Property may be omitted entirely
{ prop?: string; }
// Property must be present, but can be undefined
{ prop: string | undefined; }These have different semantics:
prop?: string- the property may not exist at allprop: string | undefined- the property always exists but may beundefined
We should audit the codebase and use the appropriate pattern based on actual intent. This affects:
- API contracts (what callers must provide)
- Serialization behavior (omitted vs explicit
undefined) - Type narrowing (
inchecks vs value checks)
Additional context
Low priority - should be addressed if time permits during v2 development.
Activity
felixweinberger commentedon Dec 16, 2025
cc @LucaButBoring FYI - tracking task-related refactoring for v2
LucaButBoring commentedon Dec 16, 2025
Depending on how soon v2 is going out I can handle this, feel free to assign me to this
felixweinberger commentedon Dec 17, 2025
We've already set up a long-lived branch
v1.xand the next release frommainis going to be a2.0.0-alphaaiming to ship early in Q1.Thanks for offering to take it on! Assigning to you for now.
LucaButBoring commentedon Dec 18, 2025
PR is up: #1315