Repository navigation
Closed
Labels
choreMaintenance: deps, build tooling, CI, cleanup — no user-facing behavior changeMaintenance: deps, build tooling, CI, cleanup — no user-facing behavior changeserver-filesystemReference implementation for the Filesystem MCP server - src/filesystemReference implementation for the Filesystem MCP server - src/filesystemserver-memoryReference implementation for the Memory MCP server - src/memoryReference implementation for the Memory MCP server - src/memoryserver-sequentialthinkingReference implementation for the Sequential Thinking MCP server - src/sequentialthinkingReference implementation for the Sequential Thinking MCP server - src/sequentialthinkingv2
Milestone
Description
Problem
The Dockerfiles for filesystem, memory and sequentialthinking build (since #5147 moved them to node:24-alpine, see #4782), but they do not install what this repository tested:
- The workspace lockfile and
overridesare ignored. Each builder stage copiessrc/<server>alone and runs a lockfile-lessnpm install, which resolves every dependency fresh on the day of the build. The rootpackage-lock.jsonand the rootpackage.jsonoverrides(the pins for transitive advisories:qs,hono,proxy-addr,ip-address, …) never reach the image. Example from theeverythingimage built the same way: it installed[email protected], where the lockfile has6.16.0. --omit-devis not an npm flag.npm ci --ignore-scripts --omit-devprintsnpm warn Unknown cli config "--omit-dev"; dev dependencies are left out only becauseNODE_ENV=productionis set. The flag is--omit=dev.- They run as root (the TypeScript half of Dockerfiles for fetch/git/time create an
appuser (since #2205) but never switch to it; all seven images run as root #4741, which covers the Python images).
Reproduce
docker build -f src/filesystem/Dockerfile -t fs-check . 2>&1 | grep -E 'omit-dev|added'Expected
Each image installs from the root lockfile with npm ci --workspace src/<server>, building from the repository root as context, with a src/<server>/Dockerfile.dockerignore allow-list. #3309's PR does this for everything (src/everything/Dockerfile); the same shape applies to the other three. Out of scope for #3309, which concerns everything only.
Metadata
Metadata
Assignees
Labels
choreMaintenance: deps, build tooling, CI, cleanup — no user-facing behavior changeMaintenance: deps, build tooling, CI, cleanup — no user-facing behavior changeserver-filesystemReference implementation for the Filesystem MCP server - src/filesystemReference implementation for the Filesystem MCP server - src/filesystemserver-memoryReference implementation for the Memory MCP server - src/memoryReference implementation for the Memory MCP server - src/memoryserver-sequentialthinkingReference implementation for the Sequential Thinking MCP server - src/sequentialthinkingReference implementation for the Sequential Thinking MCP server - src/sequentialthinkingv2
Activity
chore(docker): build filesystem, memory and sequentialthinking from t…