Repository navigation
Commit f621c75
fix(filesystem): resolve paths that differ from disk only in Unicode form (#1970)
An NFC spelling of an allowed directory whose name is NFD on disk failed
the allow-list check, a string comparison, before the Unicode walk ran.
validatePath now maps such a request onto the allowed directory's own
spelling, so the result is inside that directory by construction and
every later check still runs against the real allow-list; a request that
does not spell an allowed directory is refused as before.
The Unicode walk also treats Unicode space separators (U+202F, U+00A0)
as U+0020 when the exact name is missing, so a macOS screenshot name sent
back with a plain space before "PM" resolves instead of failing with
ENOENT. An exact match still wins, and two matches are still ambiguous.
The KNOWN BUG #1970 pinning test now asserts the corrected behavior.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: cliffhall <[email protected]>1 parent 571e2b3 commit f621c75
3 files changed
Lines changed: 124 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
273 | 272 | | |
274 | | - | |
275 | | - | |
276 | | - | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
277 | 276 | | |
278 | 277 | | |
279 | 278 | | |
| |||
283 | 282 | | |
284 | 283 | | |
285 | 284 | | |
286 | | - | |
287 | | - | |
288 | | - | |
| 285 | + | |
289 | 286 | | |
290 | 287 | | |
291 | 288 | | |
292 | 289 | | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
293 | 356 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
95 | 137 | | |
96 | 138 | | |
97 | 139 | | |
| |||
120 | 162 | | |
121 | 163 | | |
122 | 164 | | |
123 | | - | |
| 165 | + | |
124 | 166 | | |
125 | 167 | | |
126 | 168 | | |
| |||
171 | 213 | | |
172 | 214 | | |
173 | 215 | | |
174 | | - | |
| 216 | + | |
175 | 217 | | |
176 | 218 | | |
177 | 219 | | |
178 | 220 | | |
179 | 221 | | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
180 | 227 | | |
181 | 228 | | |
182 | 229 | | |
| |||
0 commit comments