Skip to content

Commit f4c86ff

Browse files
cliffhallclaude
andcommitted
fix(release): count .md changes in package matrix; use --frozen for pytest
Review findings from the PR: - release.py's has_changes() only counted .py/.ts files, so the README touches meant to enroll the four TS packages in the npm matrix would have been ignored. Include .md — READMEs ship inside the published package (npm tarball / PyPI long_description), so doc changes are release-relevant. - uv run --frozen pytest for consistency with the job's other uv calls. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01AViME1R9ES2UXT1uQDx1TG
1 parent dab3489 commit f4c86ff

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ jobs:
142142
working-directory: src/${{ matrix.package }}
143143
run: |
144144
if [ -d "tests" ] || [ -d "test" ]; then
145-
uv run pytest
145+
uv run --frozen pytest
146146
else
147147
echo "No tests directory, skipping"
148148
fi

‎scripts/release.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,9 @@ def has_changes(path: Path, git_hash: GitHash) -> bool:
113113
)
114114

115115
changed_files = [Path(f) for f in output.stdout.splitlines()]
116-
relevant_files = [f for f in changed_files if f.suffix in [".py", ".ts"]]
116+
# .md counts as a change: READMEs ship inside the published package
117+
# (npm tarball / PyPI long_description)
118+
relevant_files = [f for f in changed_files if f.suffix in [".py", ".ts", ".md"]]
117119
return len(relevant_files) >= 1
118120
except subprocess.CalledProcessError:
119121
return False

0 commit comments

Comments
 (0)