Skip to content

Commit d449df5

Browse files
cliffhallclaude
andcommitted
fix(fetch): treat role=complementary as page furniture, like aside
Copilot review on #5308. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent adae634 commit d449df5

2 files changed

Lines changed: 11 additions & 1 deletion

File tree

‎src/fetch/src/mcp_server_fetch/server.py‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,16 @@ def _is_hidden(tag: Tag) -> bool:
207207
# closed dialog): never a hydration container, so never unhidden.
208208
_PAGE_CHROME_TAGS = frozenset({"nav", "header", "footer", "aside", "menu", "dialog"})
209209
_PAGE_CHROME_ROLES = frozenset(
210-
{"navigation", "banner", "contentinfo", "menu", "menubar", "dialog", "alertdialog"}
210+
{
211+
"navigation",
212+
"banner",
213+
"contentinfo",
214+
"complementary",
215+
"menu",
216+
"menubar",
217+
"dialog",
218+
"alertdialog",
219+
}
211220
)
212221

213222

‎src/fetch/tests/test_hidden_ssr.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ async def test_page_with_small_hidden_element_is_extracted_once(
135135
('<div role="navigation" hidden>', "</div>"),
136136
("<nav><div hidden>", "</div></nav>"),
137137
('<header><div style="display:none">', "</div></header>"),
138+
('<div role="complementary"><div hidden>', "</div></div>"),
138139
],
139140
)
140141
async def test_hidden_navigation_is_left_hidden(

0 commit comments

Comments
 (0)