Skip to content

Commit a9a76fb

Browse files
cliffhallclaude
andcommitted
fix(skills): pr-flow silent-round re-request and question branch type
Step 9 allowed another round only after a pushed fix, so a silent round could never be followed by a second request and the two-silent-rounds exit was unreachable. A silent round is now re-requested without a push and without raising EXPECTED; AGENTS.md's loop rule says the same. Step 2 now says a question-labeled issue has no branch type: relabel it with the type of the change before branching. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent 41b8033 commit a9a76fb

2 files changed

Lines changed: 12 additions & 4 deletions

File tree

‎.claude/skills/pr-flow/SKILL.md‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ git switch -c v2/fix/4810-filesystem-symlink-escape origin/v2/main
4747
```
4848

4949
`<type>` follows the issue's type label: `bug` → `fix`, `enhancement` → `feat`,
50-
`documentation` → `docs`, `chore` → `chore`. The `v2/` prefix matches the base
50+
`documentation` → `docs`, `chore` → `chore`. A `question` has no branch type,
51+
because answering one ships nothing: if it turns out to need a change, relabel
52+
the issue with the type that change is, then branch. The `v2/` prefix matches the base
5153
branch and keeps the work legible in `git branch -a` next to `main`.
5254

5355
**Never cut from `main`.** It is the release line and does not carry `v2/main`'s
@@ -288,8 +290,14 @@ Push the fixes (signed off, step 3) before requesting the next round.
288290

289291
## 9. Another round, or stop
290292

291-
Request another round (step 7, with `EXPECTED` one higher) **only when you
292-
pushed a fix** in response to the last one. The loop stops at the **first** of:
293+
Request another round (step 7) in one of two cases, and no other:
294+
295+
- **You pushed a fix** in response to the last round. Raise `EXPECTED` by one.
296+
- **The last round was silent** (no review by the poll's deadline). Nothing was
297+
reviewed, so request again **without** a push and **without** raising
298+
`EXPECTED`: the count you are waiting for has not been reached yet.
299+
300+
The loop stops at the **first** of:
293301

294302
| Exit | When | Then |
295303
| --- | --- | --- |

‎AGENTS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ here.
276276
- **After opening a PR, run a Copilot review loop to convergence, unprompted.**
277277
Request a review, wait for the round to post or for Copilot's session to end
278278
without one, answer every comment, and request again only when you pushed a
279-
fix. Stop on the **first** clean round (no confirming round), a round holding
279+
fix or the last round ended without a review. Stop on the **first** clean round (no confirming round), a round holding
280280
only out-of-scope findings, two rounds in a row that end without a review, or
281281
a timeout (the loop's budget is spent while findings keep coming). The recipe
282282
is the `pr-flow` skill.

0 commit comments

Comments
 (0)