Skip to content

Commit a80becd

Browse files
cliffhallclaude
andcommitted
fix(git): find the prompt fence's length in one pass
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent be1350b commit a80becd

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

‎src/git/src/mcp_server_git/server.py‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -608,9 +608,13 @@ def _fenced(text: str, info: str = "diff") -> str:
608608
A diff can itself hold a ``` line (a Markdown file's code block), which
609609
would close a fixed three-backtick fence early.
610610
"""
611-
fence = "```"
612-
while fence in text:
613-
fence += "`"
611+
# One pass for the longest run: growing the fence and searching again for
612+
# each extra backtick is quadratic in a long run, under the git lock.
613+
longest = run = 0
614+
for char in text:
615+
run = run + 1 if char == "`" else 0
616+
longest = max(longest, run)
617+
fence = "`" * max(3, longest + 1)
614618
body = text.rstrip("\n")
615619
return f"{fence}{info}\n{body}\n{fence}"
616620

‎src/git/tests/test_prompts.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,3 +287,5 @@ def test_fence_outgrows_backticks_in_the_content() -> None:
287287
assert _fenced("plain\n") == "```diff\nplain\n```"
288288
assert _fenced("+```python\n+x\n+```\n") == ("````diff\n+```python\n+x\n+```\n````")
289289
assert _fenced("a ```` b", "text") == "`````text\na ```` b\n`````"
290+
# A long run is measured in one pass, not by growing the fence.
291+
assert _fenced("`" * 10_000).startswith("`" * 10_001 + "diff\n")

0 commit comments

Comments
 (0)