Skip to content

Commit a660ac3

Browse files
cliffhallclaude
andcommitted
fix: exempt advisory fixes from issue assignment and branch naming
The private-fork exception still left AGENTS.md's work-start rules in force: assign the issue and name the branch v2/<type>/<N>-<slug>. An advisory fix has no issue, and a descriptive slug would disclose the vulnerability. Exempt it from both and require an opaque v2/fix/<ghsa-id> branch; the skill's step 4 says the same. Refs #4870 Signed-off-by: cliffhall <[email protected]> Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent 14c2593 commit a660ac3

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

‎.claude/skills/security-advisory/SKILL.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,11 @@ reason for the read-first rule.
229229

230230
Fix and review inside the fork. The fix follows the rules in `AGENTS.md` like
231231
any other change: a regression test that fails before the fix, and the checks
232-
under **Before pushing** for the server it touches. **The fork's PR targets
233-
`v2/main`**, never `main`: check its base before anyone merges it.
232+
under **Before pushing** for the server it touches. Name the branch
233+
`v2/fix/<ghsa-id>` (lowercase, **no descriptive slug**, since a branch name
234+
outlives the fork once merged), and keep commit messages equally opaque until
235+
publication. **The fork's PR targets `v2/main`**, never `main`: check its base
236+
before anyone merges it.
234237

235238
⚠️ **Move the card as the work moves.** `In Progress` when the fix is started,
236239
`In Review` when the fork's PR is open. The fork is invisible to everyone not on

‎AGENTS.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,11 @@ holds for a maintainer's own one-line fix as much as for a feature.
188188
advisory's temporary private fork (`servers-<ghsa-id>`) links no public
189189
issue, carries no labels, and is tracked by the advisory's `[GHSA-…]` draft
190190
card rather than an issue's card, because each of those would disclose the
191-
vulnerability before a fix ships. It still targets `v2/main`, and it is
192-
reviewed inside the fork. The flow is the `security-advisory` skill.
191+
vulnerability before a fix ships. For the same reason the work-start rules
192+
on assigning an issue and naming the branch `v2/<type>/<ISSUE_NUMBER>-<slug>`
193+
do not apply: its branch is `v2/fix/<ghsa-id>`, with **no descriptive
194+
slug**. It still targets `v2/main`, and it is reviewed inside the fork. The
195+
flow is the `security-advisory` skill.
193196

194197
No other PR is exempt.
195198

0 commit comments

Comments
 (0)