Skip to content

Commit 88dd4e0

Browse files
cliffhallclaude
andcommitted
fix(ci): a mixed issue's dry-run check expects the decision to remain
Copilot round 3 on #5286. With an unpatched advisory the bump cannot clear, the dry run after the fix refreshes the issue to that advisory rather than reporting the exposure cleared; the Fix section now says so. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent c36415d commit 88dd4e0

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎scripts/dependabot-alerts.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,7 @@ export function buildIssueBody(
786786
),
787787
"",
788788
...disjointCaution(group),
789-
`**Then verify** before opening the PR: every locked copy must be outside every range in the Advisories table${unpatched.length > 0 ? " that has a patched release" : ""}. \`node scripts/dependabot-alerts.mjs --dry-run\` against the branch should report this exposure cleared.`,
789+
`**Then verify** before opening the PR: every locked copy must be outside every range in the Advisories table${unpatched.length > 0 ? " that has a patched release" : ""}. \`node scripts/dependabot-alerts.mjs --dry-run\` against the branch should ${unpatched.length > 0 ? `then refresh this issue to the advisories under **No patched release** alone, which stay tracked until they are decided` : "report this exposure cleared"}.`,
790790
"",
791791
...copies,
792792
...(unpatched.length > 0

‎scripts/dependabot-alerts.test.mjs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1313,6 +1313,10 @@ test("a bump issue carries a decision section for advisories it cannot clear", (
13131313
/### No patched release\n\nThe bump above does not clear every advisory\.\n\n\*\*No patched release is available\*\* for `GHSA-u`/,
13141314
);
13151315
assert.match(create.input, /that has a patched release\. `node scripts/);
1316+
assert.match(
1317+
create.input,
1318+
/should then refresh this issue to the advisories under \*\*No patched release\*\* alone/,
1319+
);
13161320

13171321
// An unpatched advisory arriving on an open bump issue is announced as one.
13181322
const issue = filedIssue([patched]);

0 commit comments

Comments
 (0)