Skip to content

Commit 88ae87f

Browse files
cliffhallclaude
andcommitted
fix(everything): justify the new partial-mock casts; align task docs
Copilot round 2 on #5034: give the two partial McpServer mocks this PR added the same justification comment as the existing one, and make the client-side tasks paragraph in features.md state the base capability each async tool needs (form-mode elicitation for the elicitation tool). Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent 59f5661 commit 88ae87f

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎src/everything/__tests__/registrations.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ describe("Registration Index Files", () => {
145145
registerToolTask: vi.fn(),
146146
},
147147
},
148-
} as unknown as McpServer;
148+
} as unknown as McpServer; // partial mock: McpServer's private members rule out a structural literal
149149

150150
registerConditionalTools(mockServerUrlOnly);
151151

@@ -207,7 +207,7 @@ describe("Registration Index Files", () => {
207207
registerToolTask: vi.fn(),
208208
},
209209
},
210-
} as unknown as McpServer;
210+
} as unknown as McpServer; // partial mock: McpServer's private members rule out a structural literal
211211

212212
registerConditionalTools(mockServer);
213213

‎src/everything/docs/features.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ The server advertises support for MCP Tasks, enabling long-running operations wi
8585
Use the `simulate-research-query` tool to exercise the full task lifecycle. Set `ambiguous: true` to trigger elicitation - the server will send an `elicitation/create` request directly and await the response before completing.
8686

8787
**Client-side tasks (server calls client):**
88-
Use `trigger-sampling-request-async` or `trigger-elicitation-request-async` to demonstrate bidirectional tasks where the server sends requests that the client executes as background tasks. These require the client to advertise `tasks.requests.sampling.createMessage` or `tasks.requests.elicitation.create` capabilities respectively.
88+
Use `trigger-sampling-request-async` or `trigger-elicitation-request-async` to demonstrate bidirectional tasks where the server sends requests that the client executes as background tasks. These require the client to advertise `sampling` with `tasks.requests.sampling.createMessage`, or form-mode `elicitation` with `tasks.requests.elicitation.create`, respectively.
8989

9090
### Bidirectional Task Flow
9191

0 commit comments

Comments
 (0)