You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 802c225
Browse filesBrowse the repository at this point in the historyBrowse files
test(filesystem): mark the tests that pin known bugs
The filesystem suites are characterization tests: they assert what the
server does today so the SDK v2 migration can prove it changed nothing.
Some of those assertions pin behavior that is wrong. Each such test now
carries a uniform marker directly above it (or above its describe when
every test in the block pins the same bug):
// KNOWN BUG #N: pins current (wrong) behavior; the fix changes this assertion.
or, where no issue is filed yet:
// KNOWN BUG (no issue): <what is wrong>; the fix changes this assertion.
`git grep "KNOWN BUG"` now lists exactly the bug-pinning tests. Regression
guards for fixed bugs, documented design (#3602, roots replace the
command-line directories per the README), enhancement requests (#3402)
and tests that show the server already behaves correctly (#4206, #4207)
are left unmarked. Comments only; no assertion changes.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: cliffhall <[email protected]>
// KNOWN BUG #3204: pins current (wrong) behavior; the fix changes this assertion.
160
161
// #3204: the server does not wait for the initial roots before serving
161
162
// tool calls. A call that arrives while roots/list is outstanding is
162
163
// checked against the command-line directories (here, none).
@@ -246,6 +247,7 @@ describe("a client without the roots capability", () => {
246
247
);
247
248
});
248
249
250
+
// KNOWN BUG (no issue): with no directories and no Roots, the initialization error the README promises is swallowed and the session stays up with nothing allowed; the fix changes this assertion.
249
251
// With no directories from either source, oninitialized throws. The SDK
250
252
// routes a notification handler's rejection to the server's onerror, which
251
253
// the server leaves unset, so the error is invisible to the client: the
0 commit comments