Skip to content

Commit 6d4f17c

Browse files
cliffhallclaude
andcommitted
test(memory): mark the tests that pin known bugs
The memory suites are characterization tests: they assert current behavior so the SDK v2 migration can show it changed nothing. Some of them pin behavior that is wrong. Each of those now carries a marker line directly above its it() or describe(): // KNOWN BUG #<issue>: pins current (wrong) behavior; the fix changes this assertion. or, for a bug with no issue filed, "KNOWN BUG (no issue): <what is wrong>; ...". `git grep "KNOWN BUG"` lists exactly the bug-pinning tests. Regression guards for fixed bugs (#1819, #3137, #4922) and pins of documented design carry no marker. Comments only; no assertion or test logic changes. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent fa12eae commit 6d4f17c

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

‎src/memory/__tests__/persistence.test.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ describe("memory persistence over the protocol", () => {
167167
]);
168168
});
169169

170+
// KNOWN BUG #4885: pins current (wrong) behavior; the fix changes this assertion.
170171
// Characterizes #4885: the next write rewrites the file from the filtered
171172
// graph, so every unreadable line is deleted for good, and Bob loses two
172173
// valid observations because of one null. The relation to Bob now dangles.
@@ -255,6 +256,7 @@ describe("memory persistence over the protocol", () => {
255256
});
256257
});
257258

259+
// KNOWN BUG #4827: pins current (wrong) behavior; the fix changes this assertion.
258260
// Characterizes #4827: saveGraph writes a new temp file and renames it over
259261
// the graph file, so the graph file takes a new file's mode. An operator's
260262
// 0600 is lost, and a read-only file is silently replaced. The fix for #4827
@@ -306,6 +308,7 @@ describe("memory persistence over the protocol", () => {
306308
});
307309
});
308310

311+
// KNOWN BUG #4797: pins current (wrong) behavior; the fix changes this assertion.
309312
// Characterizes #4797: the mutation lock is per server instance, so two
310313
// servers on one file (two client processes in practice) can both load the
311314
// same graph, and the second save replaces the first. Both calls report

‎src/memory/__tests__/tools.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,7 @@ describe("memory tools over the protocol", () => {
419419
expect(textOf(result)).toBe("[]");
420420
});
421421

422+
// KNOWN BUG #4887: pins current (wrong) behavior; the fix changes this assertion.
422423
it("keeps only the first of two same-named entities in one batch", async () => {
423424
const second = { ...alice, entityType: "robot", observations: ["beeps"] };
424425
const result = await call(client, "create_entities", {
@@ -428,6 +429,7 @@ describe("memory tools over the protocol", () => {
428429
expect(await readGraph()).toEqual({ entities: [alice], relations: [] });
429430
});
430431

432+
// KNOWN BUG #4887: pins current (wrong) behavior; the fix changes this assertion.
431433
// Characterizes #4887: create_entities silently drops the observations of
432434
// an entity whose name already exists. The call succeeds, reports nothing
433435
// created, and the new observation is lost. The fix for #4887 changes this

0 commit comments

Comments
 (0)