Skip to content

Commit 6033582

Browse files
cliffhallclaude
andcommitted
fix: advisory Priority mapping; pre-publication metadata and credits
Until the issue-triage rubric lands, the skill scored advisories with issue-create's table, which puts every security report at Urgent and leaves the step-2 re-score nothing to change. Map the advisory's severity instead, one level lower while unverified. The pre-publication check now covers what users and advisory tooling remediate from: the affected package, the vulnerable range, the first patched version and the verified severity. It also corrects the credit note: a privately reported advisory already credits its reporter (the credit may be pending), so the step is to confirm it, not add it. Refs #4870 Signed-off-by: cliffhall <[email protected]> Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent f3b0bcf commit 6033582

1 file changed

Lines changed: 32 additions & 7 deletions

File tree

  • .claude/skills/security-advisory

‎.claude/skills/security-advisory/SKILL.md‎

Lines changed: 32 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,20 @@ a real GitHub issue".
8383
ownership **before** severity, and a report can look severe right up until
8484
it turns out to be an SDK's code, or no vulnerability at all. So score what
8585
the report claims now, and **re-score at the end of step 2**. Until the
86-
`issue-triage` rubric lands (#4868), score with the Priority table in
87-
`/issue-create` (step 3), and write the result into the body as
86+
`issue-triage` rubric lands (#4868), map the advisory's severity with the
87+
table below. (`/issue-create`'s Priority table would put every security
88+
report at `Urgent`, which leaves the re-score nothing to change.) An
89+
unverified claim sits one level below a verified one:
90+
91+
| Advisory severity | Provisional (step 1, as claimed) | Re-scored (step 2, verified and ours) |
92+
| --- | --- | --- |
93+
| `critical` | High | Urgent |
94+
| `high` | High | Urgent |
95+
| `medium` | Medium | High |
96+
| `low` | Low | Medium |
97+
98+
Re-score by the severity you verified, which may differ from the claim.
99+
Write the result into the body as
88100
`Priority <level> (provisional, <YYYY-MM-DD>)`: a draft card has no comments,
89101
so the body is the only place the score can be recorded. When you re-score,
90102
keep that line and add the new one under it, so the change of view is
@@ -262,11 +274,23 @@ stop there.
262274
⚠️ **Publishing is irreversible and human-only.** It makes the advisory public,
263275
with no undo. Same rule as accepting: recommend, never perform.
264276

265-
**Before publishing, do the two things publishing will not do:** request a
266-
**CVE** if one is wanted (optional, and the advisory is the only place to ask),
267-
and **add the reporter to the credits**. A credit is an explicit addition that
268-
the person then has to accept, so an unadded reporter is simply never credited,
269-
and nothing reports that.
277+
**Before publishing, check what publishing will show**, because a published
278+
advisory is what users and advisory tooling (Dependabot, `npm audit`,
279+
`pip-audit`) remediate from:
280+
281+
- **The affected product**: ecosystem (`npm` or `pip`) and package name, as
282+
published (`@modelcontextprotocol/server-filesystem`, `mcp-server-git`).
283+
- **The vulnerable version range**, and the **first patched version**: the
284+
version the release actually published, which is known only once that release
285+
is out. An advisory with no patched version tells nobody how to remediate.
286+
- **The severity**, as verified in step 2 rather than as reported.
287+
- **The credits.** A privately reported advisory already credits its reporter
288+
(GitHub adds the credit on submission; it may still be pending the
289+
reporter's acceptance), so confirm it is there rather than adding it. An
290+
advisory a maintainer opened directly has no credits until someone is
291+
added, and an unadded finder is simply never credited.
292+
- **A CVE**, if one is wanted: optional, and the advisory is the only place to
293+
request one.
270294

271295
### 6. After publication, convert the card into public tracking
272296

@@ -304,5 +328,6 @@ issues and two cards.
304328
| Fork idempotency | Read `.private_fork` first; the POST creates, it does not probe |
305329
| Fork deletion | Needs the `delete_repo` OAuth scope, which a default `gh` token lacks |
306330
| Comments | **No API at all**, REST or GraphQL; UI-only |
331+
| Credits | `credits_detailed` on the advisory; a private report carries the reporter's credit (`type` `reporter`, `state` `pending` or `accepted`) from submission |
307332
| Board writes | Not automatable from Actions: `GITHUB_TOKEN` cannot hold `organization projects: write` |
308333
| SDK routing | Both SDK repos have private vulnerability reporting enabled; use their advisory forms |

0 commit comments

Comments
 (0)