You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5ea217b
Browse filesBrowse the repository at this point in the historyBrowse files
fix(filesystem): revoke access when a roots update leaves no valid root
Once the client's roots are in force, a roots/list_changed update with no valid roots now clears the allow-list instead of keeping the previous directories. Before any root has been in force, such an update keeps the command-line directories, as before. An empty allow-list now says so in its access-denied error.
Closes#5094
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: cliffhall <[email protected]>
A `roots/list_changed` update that leaves no valid root now revokes access once the client's roots are in force, instead of keeping the previous allowed directories, so a client that withdraws its roots withdraws the server's access too (#5094). Every path is then refused with "Access denied - no allowed directories" until the client exposes a root again. Before any root has been in force, such an update still keeps the command-line directories.
Copy file name to clipboardExpand all lines: src/filesystem/README.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -51,6 +51,7 @@ The server's directory access control follows this flow:
51
51
- Tool calls that arrive before the initial roots are loaded wait for them, so they are checked against the client's roots
52
52
-**On runtime updates**: Client can send `notifications/roots/list_changed`
53
53
- Server requests updated roots and replaces allowed directories again
54
+
- Once the client's roots are in force, an update with no valid roots revokes access: every path is refused ("Access denied - no allowed directories") until the client exposes a root again. Before any root has been in force, such an update keeps the command-line directories
54
55
55
56
4.**Fallback Behavior** (if client doesn't support roots)
56
57
- Server continues using command-line directories only
0 commit comments