Skip to content

Commit 4f39a54

Browse files
cliffhallclaude
andcommitted
fix: address Copilot round 3 on #5063
State the Node.js 20 floor in each server's README and note in everything's that the task tools are out until #4852. Assert that sequentialthinking advertises no execution metadata rather than skipping the test, and correct a stale v1 comment in sampling-elicitation.test.ts. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent 92eca9c commit 4f39a54

6 files changed

Lines changed: 26 additions & 5 deletions

File tree

‎src/everything/README.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@ This MCP server attempts to exercise all the features of the MCP protocol. It is
1313

1414
A complete list of the registered MCP primitives and other protocol features demonstrated can be found in the [Server Features](docs/features.md) document.
1515

16+
The task tools (`simulate-research-query`, `trigger-sampling-request-async` and `trigger-elicitation-request-async`) are not available for now: they were built on the TypeScript SDK's experimental tasks layer, which SDK v2 removed. They return on the MCP tasks extension in [#4852](https://github.com/modelcontextprotocol/servers/issues/4852).
17+
18+
## Requirements
19+
20+
Node.js 20 or later, when the server runs through `npx` or from source.
21+
1622
## Usage with Claude Desktop (uses [stdio Transport](https://modelcontextprotocol.io/specification/2025-03-26/basic/transports#stdio))
1723

1824
Add to your `claude_desktop_config.json`:

‎src/everything/__tests__/sampling-elicitation.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,8 @@ describe("trigger-url-elicitation", () => {
479479
expect(error).toBeInstanceOf(ProtocolError);
480480
const mcpError = error as ProtocolError;
481481
expect(mcpError.code).toBe(-32042);
482-
// The SDK prefixes the code twice on the client side.
482+
// SDK v2 passes the server's message through verbatim (SDK 1.x prefixed
483+
// "MCP error -32042: " twice on the client side).
483484
expect(mcpError.message).toBe(
484485
"This request requires browser-based authorization.",
485486
);

‎src/filesystem/README.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,10 @@ The mapping for filesystem tools is:
216216

217217
> Note: `idempotentHint` and `destructiveHint` are meaningful only when `readOnlyHint` is `false`, as defined by the MCP spec. Every tool also sets `openWorldHint: false` — this server only accesses the local filesystem within its allowed directories, never an open or external world.
218218
219+
## Requirements
220+
221+
Node.js 20 or later, when the server runs through `npx` or from source.
222+
219223
## Usage with Claude Desktop
220224
Add this to your `claude_desktop_config.json`:
221225

‎src/memory/README.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,10 @@ Example:
137137
- Returns the same shape as `read_graph` (entities and relations)
138138
- Mutation tools (`create_entities`, `create_relations`, `add_observations`, `delete_entities`, `delete_observations`, `delete_relations`) emit `notifications/resources/updated` for this URI, so subscribed clients see live changes
139139

140+
## Requirements
141+
142+
Node.js 20 or later, when the server runs through `npx` or from source.
143+
140144
# Usage with Claude Desktop
141145

142146
### Setup

‎src/sequentialthinking/README.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,10 @@ After installing the server in your MCP host:
6969
3. Ask the host to solve a non-trivial problem in a step-by-step way.
7070
4. Verify that the host invokes the tool multiple times instead of returning a one-shot answer.
7171

72+
## Requirements
73+
74+
Node.js 20 or later, when the server runs through `npx` or from source.
75+
7276
## Configuration
7377

7478
### Usage with Claude Desktop

‎src/sequentialthinking/__tests__/tools-list.test.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,12 @@ describe("sequentialthinking: initialize and tools/list", () => {
6464
});
6565
});
6666

67-
// SDK v2 removed the experimental tasks layer and no longer advertises
68-
// `execution.taskSupport`; Part 5 (#4852) restores task semantics.
69-
it.skip("forbids task-augmented execution", () => {
70-
expect(tool.execution).toEqual({ taskSupport: "forbidden" });
67+
// SDK 1.x advertised `execution: { taskSupport: "forbidden" }`. SDK v2
68+
// removed the experimental tasks layer and advertises no `execution` at
69+
// all; Part 5 (#4852) decides what the tool advertises under the tasks
70+
// extension.
71+
it("advertises no task-execution metadata", () => {
72+
expect(tool.execution).toBeUndefined();
7173
});
7274

7375
// #799: some clients cap a tool description at 1024 characters. This one is

0 commit comments

Comments
 (0)