Skip to content

Commit 473c531

Browse files
cliffhallclaude
andcommitted
Record the SDK watch's accepted credential-channel risk (#5069)
The maintainers accepted the analysis job's residual credential channel on #5069: every upstream the SDK watch reads is an MCP-org SDK, and those are trusted, including their generated release notes' outside PR titles. The workflow note now cites that decision instead of the Inspector's reasoning, AGENTS.md states the rule, and a test fails on an SDK group outside the modelcontextprotocol org, so the decision is taken again before one is added. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent 371190b commit 473c531

3 files changed

Lines changed: 25 additions & 7 deletions

File tree

‎.github/workflows/sdk-watch.yml‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -205,13 +205,15 @@ jobs:
205205
# copies its environment into the model's, so `ANTHROPIC_API_KEY` is
206206
# readable by a `Read` this job needs, and `analysis` is
207207
# model-controlled text this workflow publishes. The verbatim scans
208-
# below catch the naive shape only. What makes that acceptable is what
209-
# this job reads: both upstreams (`typescript-sdk`, `python-sdk`) are
210-
# in this repository's own org, so their release notes are first-party
211-
# content, and anyone able to plant an injection there already holds
212-
# release rights here. Point this at an upstream outside the org and
213-
# that judgement has to be re-opened: workload identity federation, or
214-
# a dedicated CI-scoped key with a spend cap, is then the next step.
208+
# below catch the naive shape only. The maintainers accepted that
209+
# risk on #5069: every upstream this job reads (`typescript-sdk`,
210+
# `python-sdk`) is an MCP-org SDK, and those are trusted. That holds
211+
# even though GitHub-generated release notes list PR titles that
212+
# outside contributors wrote, which the decision weighed. Point this
213+
# at an upstream outside the MCP org and the decision has to be taken
214+
# again first: workload identity federation, or a dedicated CI-scoped
215+
# key with a spend cap, is then the next step.
216+
# `sdk-watch.test.mjs` fails on an SDK group outside the org.
215217
claude_args: |
216218
--model claude-opus-5-5
217219
--max-turns 40

‎AGENTS.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,13 @@ projects: write`. A sweep issue arrives labeled `v2` + `chore` +
249249
analysis is scanned for credentials before it is written out and again before
250250
it is posted. `sdk-watch.test.mjs` pins each of these; keep them when editing
251251
the job.
252+
- **The analysis job's residual credential channel is an accepted risk, for
253+
MCP-org upstreams only** (#5069). The model can read `ANTHROPIC_API_KEY`, and
254+
its write-up is published, so an encoded key would pass the scans. The
255+
maintainers accept that because every SDK the watch reads is an MCP-org SDK.
256+
**An SDK group outside the `modelcontextprotocol` org needs that decision
257+
taken again first** (federation, or a spend-capped CI key), and
258+
`sdk-watch.test.mjs` fails until it is.
252259

253260
## Project status and direction
254261

‎scripts/sdk-watch.test.mjs‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,15 @@ const sweepLabels = [
4646
{ name: "dependencies" },
4747
];
4848

49+
test("every SDK group is an MCP-org upstream (the #5069 risk acceptance)", () => {
50+
// The analysis job's residual credential channel is accepted only because
51+
// these upstreams are trusted MCP-org SDKs. A group outside the org needs
52+
// that decision taken again before it is added here.
53+
for (const g of SDK_GROUPS) {
54+
assert.match(g.repo, /^modelcontextprotocol\//, `${g.key}: ${g.repo}`);
55+
}
56+
});
57+
4958
test("markers round-trip", () => {
5059
const marker = buildMarker(group("python-sdk"), "2.3.0");
5160
assert.deepEqual(parseMarker(`${marker}\nbody`), {

0 commit comments

Comments
 (0)