Skip to content

Commit 4633b76

Browse files
cliffhallclaude
andcommitted
docs: test:scripts in the root guards, #4860 handoff, fixed ToC anchor
- test:scripts is inventoried and runs in S3's root-guards job - Whichever of S10 and #4860 lands second adds the interface diff to local:gate - The ToC points at the renamed Maintainer decisions section Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 8d00729 commit 4633b76

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

‎docs/agent-guidance-inception.md‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ the Inspector's `v2/main` at the time, not this doc's summary of it.
2727
7. [Existing issues to reconcile](#7-existing-issues-to-reconcile)
2828
8. [Findings along the way](#8-findings-along-the-way)
2929
9. [Proposed sub-issues](#9-proposed-sub-issues)
30-
10. [Open questions for maintainers](#10-open-questions-for-maintainers)
30+
10. [Maintainer decisions](#10-maintainer-decisions)
3131

3232
## 1. What the factory is
3333

@@ -126,6 +126,7 @@ The **Sub-issue** column points into [§9](#9-proposed-sub-issues).
126126
| `lint:*` (`--max-warnings 0`) | ESLint flat config, type-aware | Adapt | Root flat config across workspaces; `ruff check` for Python (not run in CI today) | S3, S4 |
127127
| `gate-lease.mjs` | Machine-wide FIFO lease so concurrent sessions' gates queue | Transfer | Our gates are cheaper, but concurrent sessions still contend. Also needed if any stage binds a fixed port (HTTP transport tests) | S10 |
128128
| `lib/workflow-gate.mjs` (+ tests) | Keeps the local gate out of CI: no workflow may invoke a `local:*` script, and `local:gate` stays exactly the lease wrapper | Adapt | Same invariant for our `local:*` namespace; the Inspector's engine-pass specifics drop out | S10 |
129+
| `test:scripts` | Runs every `scripts/**/*.test.mjs` under `node --test`, inside `validate:guards`, so a regression in a guard script fails the gate | Transfer | Keep the exact `*.test.mjs` naming: `node --test` silently skips a file its glob misses | S2 (adds it), S3 (root-guards job) |
129130
| `verify:skills` / `verify:skills:cli` / `lib/skill-manifest.mjs` | Frontmatter parse, explicit invocation mode, eval cases, listing budget; `claude plugin validate` at a pinned CLI | Transfer | — | S2 |
130131
| `skills:eval` (`skill-eval.mjs`, `lib/claude-cli.mjs`) | Runs each skill's eval cases headless (Claude or Copilot); trigger rate, chains, negatives | Transfer | — | S2 |
131132
| `verify:format-coverage` | Every first-party file is format-gated | Adapt | Workspace globs; Python via ruff config | S3 |
@@ -453,7 +454,8 @@ W6 S13 dependency & SDK sweeps replace Dependabot PRs; closing factory overview
453454
own package's** `validate` rather than the whole monorepo. A separate
454455
**root-guards CI job** runs what no package leg covers: the root `format`
455456
and `lint` of root files, `verify:format-coverage`,
456-
`verify:typecheck-coverage`, and the shared-devDependency version guard
457+
`verify:typecheck-coverage`, `test:scripts` (the guard scripts' own unit
458+
tests), and the shared-devDependency version guard
457459
adapted from `verify:dep-lockstep` (§2.3). Add the format/lint/validate
458460
rules to `AGENTS.md`. If S1 hasn't merged yet, hand these rules to S1
459461
instead, the same fallback as S2.
@@ -561,8 +563,9 @@ S5 and S8)
561563
S2, S3, S4, #4854, #4855)
562564
- Scope: root `local:gate` (under `gate-lease`) chaining the TS and Python
563565
validate, `verify:skills:cli`, per-file coverage for both languages, a thin
564-
per-server boot smoke over each transport the server implements (stdio for all seven; SSE and Streamable HTTP for `everything`), and #4860's interface diff
565-
once landed. `workflow-gate` ported, so no workflow can invoke a
566+
per-server boot smoke over each transport the server implements (stdio for all seven; SSE and Streamable HTTP for `everything`), and #4860's interface diff.
567+
#4860 is independent, so **whichever of S10 and #4860 lands second** wires
568+
the interface diff into `local:gate`, keeping "every check CI runs" true. `workflow-gate` ported, so no workflow can invoke a
566569
`local:*` script. CI runs coverage as a **parallel job** (§7). `timeout-minutes`
567570
on every job. No test retries (asserted). `docs/quality-gate.md`. The
568571
`pre-push-gate` skill. The `AGENTS.md` rules: mandatory pre-push gate, and

0 commit comments

Comments
 (0)