Skip to content

Commit 2c85fb4

Browse files
cliffhallclaude
andcommitted
fix: correct an exit code, a log stream, a path and the LLM-client era note
Copilot round 5 on #4921. - client-smoke: an unreachable HTTP server exits 4 with code "unreachable", not 1. The LLM-client paragraph no longer contradicts pr-flow: it says what to record when the client gives no way to choose an era. - local-dev: Streamable HTTP logs requests to stdout, not stderr. - project-structure: extension.md is given with its full path. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent d81ea3f commit 2c85fb4

3 files changed

Lines changed: 17 additions & 6 deletions

File tree

‎.claude/skills/client-smoke/SKILL.md‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,12 @@ The exit code is the verdict, so check it rather than reading the text:
111111
| The request succeeded | `{"result": …}` | | 0 |
112112
| The tool ran and returned `isError: true` | `{"result":{"content": …, "isError": true}}` | `{"error":{"code":"tool_is_error", …}}` | 5 |
113113
| No such tool | | `{"error":{"code":"tool_not_found", …}}` | 5 |
114-
| Could not connect, or bad arguments | | `{"error":{"code":"error", …}}` | 1 |
114+
| An HTTP server could not be reached (refused, DNS, timeout) | | `{"error":{"code":"unreachable", …}}` | 4 |
115+
| Bad arguments, a failed version negotiation, or a stdio server that exited | | `{"error":{"code":"error", …}}` | 1 |
116+
117+
These are the codes observed on 2.9.0 for the cases this repo's servers
118+
produce; the CLI defines others (schema and skill checks, authentication)
119+
that its `--help` describes.
115120

116121
A tool error is a **successful protocol exchange**: the result object is still
117122
printed on stdout, and it is what to quote when the change is about an error a
@@ -231,9 +236,12 @@ addressed as `mcp__<server name in the config>__<tool name>`, and only the
231236
tools listed in `--allowedTools` can be called without a prompt. Keep the
232237
config file outside the worktree.
233238

234-
An LLM client does not report which protocol version it negotiated, and offers
235-
no era switch. Record the client and its version; do not present an LLM run as
236-
evidence for a particular era.
239+
Claude Code, run this way, has no era switch and does not print the protocol
240+
version it negotiated. `/pr-flow` asks for the LLM client in both eras as well;
241+
where the client gives no way to choose, record the client and its version and
242+
say that the era could not be selected, rather than labelling the run with an
243+
era it was not shown to use. Against a v1-SDK server the connection is legacy
244+
whatever the client prefers, for the reason given under Protocol eras.
237245

238246
## What to write down
239247

‎.claude/skills/local-dev/SKILL.md‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,10 @@ PORT=3917 node src/everything/dist/index.js streamableHttp
7070
Both HTTP transports listen on `PORT`, default `3001`, so they cannot run side
7171
by side without setting it. Streamable HTTP serves POST, GET and DELETE on
7272
`/mcp`. HTTP+SSE serves `GET /sse` and `POST /message`; it is deprecated, kept
73-
working, and never the transport to recommend. Both log to stderr.
73+
working, and never the transport to recommend. The two log to different
74+
streams: HTTP+SSE writes everything to stderr, while Streamable HTTP writes its
75+
request and session messages to stdout and its `listening on port` line and
76+
errors to stderr.
7477

7578
## Run the local package the way a user would
7679

‎.claude/skills/project-structure/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Three things about `everything` that the table cannot hold:
4646
`docs/instructions.md` is returned as the server's `instructions`. A file
4747
added there becomes a resource a client can list.
4848
- **Its own maps are `src/everything/docs/structure.md` and
49-
`docs/extension.md`.** A change to the server's files updates
49+
`src/everything/docs/extension.md`.** A change to the server's files updates
5050
`structure.md`, and `src/everything/AGENTS.md` holds the rules that apply
5151
only inside that directory.
5252

0 commit comments

Comments
 (0)