You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2392c9e
Browse filesBrowse the repository at this point in the historyBrowse files
fix: pack:verify never deletes an --out directory; node runs the bin on Windows; the audit stops on a failed export
- --out refuses a per-server directory that exists and is not empty, instead
of removing it: --out src would have deleted src/<server>.
- On Windows the installed package's bin file is handed to node. npm's .cmd
shim cannot be spawned without a shell, which the HTTP transports' launch
does not use.
- The release skill's Python audit exports to a file and stops on a failed
or empty export, which pip-audit would otherwise report as clean.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Signed-off-by: cliffhall <[email protected]>
* Why `dir` cannot be used as a server's artifact directory, or `null` when it
190
+
* can. It must not exist, or be empty: this script writes the artifact there
191
+
* and the release workflow uploads the directory whole, so anything already
192
+
* in it would either be uploaded with the artifact or have to be deleted, and
193
+
* a path given by mistake (`--out src` resolves to `src/<server>`) must never
194
+
* be deleted.
195
+
*
196
+
* @param {string} dir
197
+
* @returns {string | null}
198
+
*/
199
+
exportfunctionartifactDirProblem(dir){
200
+
if(!existsSync(dir))returnnull;
201
+
if(!statSync(dir).isDirectory())
202
+
return`${dir} exists and is not a directory`;
203
+
if(readdirSync(dir).length>0)
204
+
return`${dir} already exists and is not empty. Choose a fresh --out directory, or clear that one yourself; pack:verify does not delete what it did not create.`;
205
+
returnnull;
160
206
}
161
207
162
208
/** Is this file name something PyPI accepts: a wheel or an sdist? */
@@ -183,7 +229,7 @@ function run(command, args, cwd) {
183
229
/**
184
230
* Pack a TypeScript server and install the tarball into `consumer`.
0 commit comments