Skip to content

Commit 004608f

Browse files
cliffhallclaude
andcommitted
test(everything): cite the newly filed issues in KNOWN BUG markers
The bugs these tests pin had no issue when the markers were added, so the markers read "KNOWN BUG (no issue)". They are now filed under the Wave 2 tracker #5004, so each marker cites its issue number. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent 2daa141 commit 004608f

7 files changed

Lines changed: 15 additions & 15 deletions

File tree

‎src/everything/__tests__/prompts.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ describe("resource-prompt", () => {
9696
});
9797
});
9898

99-
// KNOWN BUG (no issue): blobResource() labels blob content text/plain instead of a binary MIME type; the fix changes this assertion.
99+
// KNOWN BUG #4984: blobResource() labels blob content text/plain instead of a binary MIME type; the fix changes this assertion.
100100
it("embeds a blob resource", async () => {
101101
const result = await session.client.getPrompt({
102102
name: "resource-prompt",

‎src/everything/__tests__/resources.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe("dynamic resource templates", () => {
6161
]);
6262
});
6363

64-
// KNOWN BUG (no issue): blobResource() labels blob content text/plain instead of a binary MIME type; the fix changes this assertion.
64+
// KNOWN BUG #4984: blobResource() labels blob content text/plain instead of a binary MIME type; the fix changes this assertion.
6565
it("fabricates a blob resource from its id, labelled text/plain", async () => {
6666
// Characterization: the template advertises application/octet-stream,
6767
// but the content says text/plain (#4854 baseline).

‎src/everything/__tests__/sampling-elicitation.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ describe("trigger-elicitation-request", () => {
388388
expect(texts[0]).toBe("⚠️ User cancelled the elicitation dialog.");
389389
});
390390

391-
// KNOWN BUG (no issue): trigger-elicitation-request is listed for a URL-only elicitation client, whose call then fails; the fix changes this assertion.
391+
// KNOWN BUG #4985: trigger-elicitation-request is listed for a URL-only elicitation client, whose call then fails; the fix changes this assertion.
392392
it("is listed for a URL-only client, which then cannot answer its form request", async () => {
393393
// Characterization: the tool is gated on `elicitation` alone, so a
394394
// client that declared only URL mode sees it and the call fails.

‎src/everything/__tests__/sse.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ describe("SSE transport", () => {
8383
await Promise.all([a.client.close(), b.client.close()]);
8484
});
8585

86-
// KNOWN BUG (no issue): POST /message for an unknown session is never answered; the fix changes this assertion.
86+
// KNOWN BUG #4981: POST /message for an unknown session is never answered; the fix changes this assertion.
8787
it("forgets the session and cleans up when the stream closes", async () => {
8888
const { client, sessionId } = await connectSse();
8989
await client.close();
@@ -105,7 +105,7 @@ describe("SSE transport", () => {
105105
);
106106
});
107107

108-
// KNOWN BUG (no issue): POST /message for an unknown session is never answered; the fix changes this assertion.
108+
// KNOWN BUG #4981: POST /message for an unknown session is never answered; the fix changes this assertion.
109109
it("never answers a POST for an unknown session", async () => {
110110
expect(
111111
await respondsWithin(`${base}/message?sessionId=nope`, {
@@ -116,7 +116,7 @@ describe("SSE transport", () => {
116116
expect(error).toHaveBeenCalledWith("No transport found for sessionId nope");
117117
});
118118

119-
// KNOWN BUG (no issue): a second GET /sse for an existing session is never answered; the fix changes this assertion.
119+
// KNOWN BUG #4981: a second GET /sse for an existing session is never answered; the fix changes this assertion.
120120
it("never answers a second GET /sse for an existing session, and only logs it", async () => {
121121
const { client, sessionId } = await connectSse();
122122
expect(await respondsWithin(`${base}/sse?sessionId=${sessionId}`, {})).toBe(
@@ -129,7 +129,7 @@ describe("SSE transport", () => {
129129
await client.close();
130130
});
131131

132-
// KNOWN BUG (no issue): GET /sse?sessionId=<unknown> throws a TypeError that surfaces as a 500; the fix changes this assertion.
132+
// KNOWN BUG #4981: GET /sse?sessionId=<unknown> throws a TypeError that surfaces as a 500; the fix changes this assertion.
133133
it("fails a GET /sse for an unknown session id with a 500", async () => {
134134
// Characterization: the reconnect branch reads `.sessionId` of a missing
135135
// transport, and Express turns the TypeError into a 500.

‎src/everything/__tests__/streamable-http.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ describe("Streamable HTTP transport", () => {
241241
},
242242
);
243243

244-
// KNOWN BUG (no issue): answers 400, not the 404 the spec requires, for an unknown or terminated session ID; the fix changes this assertion.
244+
// KNOWN BUG #4982: answers 400, not the 404 the spec requires, for an unknown or terminated session ID; the fix changes this assertion.
245245
it.each(["GET", "DELETE"])(
246246
"answers %s for an unknown session with a 400",
247247
async (method) => {
@@ -254,7 +254,7 @@ describe("Streamable HTTP transport", () => {
254254
},
255255
);
256256

257-
// KNOWN BUG (no issue): answers 400, not the 404 the spec requires, for an unknown or terminated session ID, and the error omits the request id; the fix changes this assertion.
257+
// KNOWN BUG #4982: answers 400, not the 404 the spec requires, for an unknown or terminated session ID, and the error omits the request id; the fix changes this assertion.
258258
it("answers a POST for an unknown session with a 400 that omits the request id", async () => {
259259
// Characterization: no body parser runs before this check, so
260260
// `req.body` is undefined and the error carries no `id`.
@@ -275,7 +275,7 @@ describe("Streamable HTTP transport", () => {
275275
});
276276
});
277277

278-
// KNOWN BUG (no issue): answers 400, not the 404 the spec requires, for an unknown or terminated session ID; the fix changes this assertion.
278+
// KNOWN BUG #4982: answers 400, not the 404 the spec requires, for an unknown or terminated session ID; the fix changes this assertion.
279279
it("ends a session on DELETE, cleaning it up and refusing it afterwards", async () => {
280280
const { client, transport, sessionId } = await connectHttp();
281281
await transport.terminateSession();
@@ -378,7 +378,7 @@ describe("Streamable HTTP transport", () => {
378378
});
379379

380380
describe("shutdown", () => {
381-
// KNOWN BUG (no issue): the SIGINT handler walks the session Map with for...in, so it never closes a session; the fix changes this assertion.
381+
// KNOWN BUG #4983: the SIGINT handler walks the session Map with for...in, so it never closes a session; the fix changes this assertion.
382382
it("logs and exits 0 without closing any session", async () => {
383383
// Characterization: the handler walks the session Map with `for...in`,
384384
// which visits no entries, so no transport is closed (#4854 baseline).

‎src/everything/__tests__/tasks.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ describe("trigger-sampling-request-async", () => {
422422
);
423423
});
424424

425-
// KNOWN BUG (no issue): trigger-sampling-request-async drops the status message of a task that is already finished when created; the fix changes this assertion.
425+
// KNOWN BUG #4987: trigger-sampling-request-async drops the status message of a task that is already finished when created; the fix changes this assertion.
426426
it("does not poll a client task that is already finished when it is created", async () => {
427427
// Characterization: the status message is only read from polls, so a
428428
// task that fails before it is returned is reported with "No message".
@@ -586,7 +586,7 @@ describe("trigger-elicitation-request-async", () => {
586586
);
587587
});
588588

589-
// KNOWN BUG (no issue): trigger-elicitation-request-async polls for longer than the 10-minute TTL it requests for its task; the fix changes this assertion.
589+
// KNOWN BUG #4986: trigger-elicitation-request-async polls for longer than the 10-minute TTL it requests for its task; the fix changes this assertion.
590590
it("fails on the last poll instead when the client honors the 10-minute TTL", async () => {
591591
// Characterization: 600 one-second polls outlast the 600000 ms TTL the
592592
// tool asks for, so a client that expires the task on time answers the

‎src/everything/__tests__/tools.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ describe("trigger-long-running-operation", () => {
206206
});
207207

208208
describe("get-resource-links", () => {
209-
// KNOWN BUG (no issue): blobResource() labels blob content text/plain instead of a binary MIME type; the fix changes this assertion.
209+
// KNOWN BUG #4984: blobResource() labels blob content text/plain instead of a binary MIME type; the fix changes this assertion.
210210
it("returns three links by default, blob for odd ids and text for even", async () => {
211211
const result = await call("get-resource-links");
212212
const content = contentOf(result);
@@ -271,7 +271,7 @@ describe("get-resource-reference", () => {
271271
);
272272
});
273273

274-
// KNOWN BUG (no issue): blobResource() labels blob content text/plain instead of a binary MIME type; the fix changes this assertion.
274+
// KNOWN BUG #4984: blobResource() labels blob content text/plain instead of a binary MIME type; the fix changes this assertion.
275275
it("returns an embedded blob resource", async () => {
276276
const result = await call("get-resource-reference", {
277277
resourceType: "Blob",

0 commit comments

Comments
 (0)