Repository navigation
Conversation
|
Cross-validated this PR against live registry data (same protocol as the #1555 cross-validation). Disclosure: Method
Results
Together with #1555 (class A), this covers classes A–C of #1546; class D ( |
|
Found a compatibility regression that we should address before merging: the positional-argument check rejects The published 2025-12-11 schema requires the I reproduced this with a full manifest that passes the published JSON Schema but fails this PR's semantic validation and receives HTTP 422 from Please preserve the distinction between an absent value and an explicitly empty value, and add a regression test for the raw JSON case above. The invalid argument-type validation looks reasonable; this finding concerns the positional value-presence check. |
053877e to
1ac3761
Compare
|
Implemented the empty-argument compatibility fix in 1ac3761 and rebased onto current main.
Added raw-JSON publish coverage for both Local validation passed: |
rdimitrov
left a comment
rdimitrov
left a comment
There was a problem hiding this comment.
Reviewed the updated head, including the explicit-empty-string follow-up I implemented. Positional validation now checks presence, and JSON round-trip coverage verifies that empty strings survive publish, JSONB storage, and responses on both API routes and argument locations. Invalid types and missing positional properties remain rejected. Local race tests, vet, lint, schema/example validation, and build passed. Merge remains conditional on required CI checks passing.
Summary
Publish accepts arguments that violate the schema.
validateArgumentonly checks the named branch, so atypethat is empty or outside the enum passes through, and a positional argument with neithervaluenorvalueHintalso passes. The scan in #1546 counted 52 entries with bad argument types and 8 bare positional ones, my own paging of /v0/servers found even more of the first kind. One I checked by hand:io.github.Jordan-Horner/[email protected](empty type under packageArguments), another iscom.keyboardcrumbs/[email protected](type "literal", still active). Every published schema version requirestypeto be "positional" or "named" and positional args to carryvalueorvalueHint. Relates to #1546, the empty repository case is #1555's, and version "latest" is already handled since #413.Change
validateArgumentbecomes a switch. Named branch unchanged. Positional now requiresvalueorvalueHint. Unknown or emptytypeis rejected. Two new errors in constants.go, referencesinvalid-argument-typeandpositional-argument-value-or-hint-required.Why not full schema validation at publish: the enhanced validation design doc gates that behind the anyOf error consolidation (Phase 3), raw anyOf failures on arguments come out as a noisy multi-error cluster. These two checks give one clean message each and are one case arm each, easy to delete at Phase 5 when schema-first lands. Until then publish and edit just agree with what /v0/validate already reports.
Heads up on two consequences: editing a stored server that still carries one of these legacy arguments will 422 until the argument is fixed, and the importer skips invalid servers with a warning, so a re-seed from a live dump drops those entries instead of failing. Also #1339 adds a check inside the named branch of the same function, whichever lands second has a small conflict to resolve there, happy to do it from my side.
Test
Tests first, they fail on main, the handler regression actually publishes an empty-type argument with 200 on main and gets 422 with the fix. On the branch: go test ./internal/... all green including the handler tests against postgres, golangci-lint v2.13.1 (what CI pins) 0 issues, make validate passes. Two existing fixtures had positional args with neither value nor valueHint, they got a valueHint since no published schema version ever allowed that shape. New error paths and references are pinned in validation_detailed_test.go.
AI Disclosure
AI assistance (Claude) was used for issue research and during development. All changes were reviewed and tested by the author.