You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
tests: treat only deleted servers as reusable for remote URL validation - #1204
@stationeros Thank you raising for the PR 👍 . Few points as per the design of status behaviour:
Remote url attached to a deprecated server is a valid URL. Deprecated server can still be an active server for downstream clients. It might not be maintained by the owner. If a user wants to publish a new package with this remote url, they have to mark this as deleted first.
Migrating from deleted to active and vice versa are the 2 status that require remote url validation.
If we are updating a server then also we have to check for remote url validation.
stationeros
changed the title
fix: ignore deprecated servers in remote URL conflict checks
fix: treat only deleted servers as reusable for remote URL validation
Apr 25, 2026
@stationeros We might not need this change, except for test cases. As this behaviour is already part of code where the default value is to exclude deleted servers. If you will run the test cases without the filter change, you will notice that tests are passing.
Reason for the issue is different where status of servers are not marked as deleted. Apologies from my end, I missed checking the default values first. But we might need test cases though. I appreciate your contribution and patience here.
@stationeros We might not need this change, except for test cases. As this behaviour is already part of code where the default value is to exclude deleted servers. If you will run the test cases without the filter change, you will notice that tests are passing.
Reason for the issue is different where status of servers are not marked as deleted. Apologies from my end, I missed checking the default values first. But we might need test cases though. I appreciate your contribution and patience here.
nvm - reverted the logic and kept the TCs if that helps
stationeros
changed the title
fix: treat only deleted servers as reusable for remote URL validation
tests: treat only deleted servers as reusable for remote URL validation
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added targeted service-layer test coverage for the main scenarios: