Support embedding resource contents in prompts #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp-ant
approved these changes
Nov 5, 2024
Comment on lines
+568
to
+577
| /** | ||
| * The contents of a resource, embedded into a prompt. | ||
| * | ||
| * It is up to the client how best to render embedded resources for the benefit | ||
| * of the LLM and/or the user. | ||
| */ | ||
| export interface PromptResourceContents extends ResourceContents { | ||
| type: "resource"; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I see. So we are still referencing an actual resource. When you said "embedded" I originally thought you meant directly returning bytes/strings here.
Member
Author
There was a problem hiding this comment.
It does directly return bytes/strings—that comes from extending ResourceContents. This is just a type tag.
Member
Author
There was a problem hiding this comment.
Ah, yeah, this is a bit confusing. Follow-up: #36
jspahrsummers
added a commit
that referenced
this pull request
Mar 12, 2025
use httpx.AsyncClient for async http requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2.
This technically breaks backwards compatibility (adds something new that the client MUST handle), but since no servers use this yet, I don't think we need to rev the protocol version. I did consider adding a capability to make this more optional, but:
ClientCapabilitiesis quite sparse, and adding a top-level key likeprompts(so we could have, e.g.,prompts.embeddedResources = true) sounds like "does the client support prompts at all?"—which would be an even bigger breaking change than this