[Bug Fix] make server/discover support caching#2855
Merged
dsp-ant merged 7 commits intoJun 4, 2026
Conversation
CaitieM20
added
bug
There was a problem hiding this comment.
Pull request overview
This PR updates the draft MCP schema and specification to treat server/discover as a cacheable operation, aligning it with the existing caching model used for list and resource-read results.
Changes:
- Make
DiscoverResultcacheable by requiringttlMsandcacheScopein the TypeScript schema and JSON Schema. - Update discovery examples to include caching hints.
- Update specification docs to explicitly declare caching support for relevant operations and link to the caching utility doc.
Show a summary per file
| File | Description |
|---|---|
| schema/draft/schema.ts | Updates DiscoverResult to extend CacheableResult so caching hints are required. |
| schema/draft/schema.json | Adds ttlMs/cacheScope (required) to the DiscoverResult JSON Schema. |
| schema/draft/examples/DiscoverResultResponse/discover-result-response.json | Updates the discover response example to include caching fields. |
| schema/draft/examples/DiscoverResult/server-capabilities-discovery.json | Updates the discover result example to include caching fields. |
| docs/specification/draft/server/utilities/caching.mdx | Adds server/discover to the list of cacheable operations. |
| docs/specification/draft/server/tools.mdx | Notes that tools/list supports caching and links to caching docs. |
| docs/specification/draft/server/resources.mdx | Notes caching support for list/read/templates operations and links to caching docs. |
| docs/specification/draft/server/prompts.mdx | Notes that prompts/list supports caching and links to caching docs. |
| docs/specification/draft/server/discover.mdx | Notes caching support for server/discover and documents the caching fields. |
| docs/specification/draft/schema.mdx | Regenerates schema documentation to include the new cacheable fields on DiscoverResult. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 10/10 changed files
- Comments generated: 2
kurtisvg
previously approved these changes
Jun 3, 2026
dsp-ant
previously approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue identified during Core-Maintainer RC Specification review on 6/3/26
Motivation and Context
Due to timing around SEPs landing we missed adding server/discover as a cacheable result. This change updates the schema & specification docs to support this.
Also added language to each cacheable result doc to declare support and link back to caching.mdx.
How Has This Been Tested?
conformance tests for this feature already exist.
Breaking Changes
no
Types of changes
Checklist
Additional context