Repository navigation
Conversation
Member
|
LGTM - seems the sensible solution to extensibility here. |
CaitieM20
reviewed
May 27, 2026
CaitieM20
reviewed
May 27, 2026
CaitieM20
requested changes
May 27, 2026
CaitieM20
left a comment
Contributor
There was a problem hiding this comment.
requested some spec wording changes for clarity
LucaButBoring
force-pushed
the
fix/resultType-extensibility
branch
from
May 27, 2026 17:55
532952e to
93c027f
Compare
Contributor
Author
|
Updated and rebased |
Contributor
|
Looks good to me! |
CaitieM20
approved these changes
May 28, 2026
LucaButBoring
added a commit
to modelcontextprotocol/ext-tasks
that referenced
this pull request
May 28, 2026
LucaButBoring
added a commit
to modelcontextprotocol/agents-wg
that referenced
this pull request
May 28, 2026
jakemac53
pushed a commit
to dart-lang/ai
that referenced
this pull request
Jul 24, 2026
First slice of the 2026-07-28 core-protocol support tracked in #162, split out from the HTTP transport work to keep it small and reviewable on its own. Adds the `resultType` result field as an additive, non-breaking API: - `Result.resultType` reads the field. A null value means the server did not send it; callers treat null as `complete`, the backward-compatible convention the 2026-07-28 schema requires for results from servers on earlier protocol versions. See modelcontextprotocol/modelcontextprotocol#2726, which reframes an absent `resultType` as backward compatibility. - The getter is a nullable `String`, exactly matching `CreateMessageResult.stopReason` (both `String?`), the open union this package already has. The schema types `resultType` as `"complete" | "input_required" | string`, so a server may send a value this package does not know. A closed `enum` cannot represent that set; it would have to throw on an unknown value or fold it into a fallback constant, and both lose the string the server actually sent. See modelcontextprotocol/modelcontextprotocol#2773, the SEP-2322 fix that made `ResultType` an open union so servers can extend it. - No `latestSupported` bump and no server-side emission; those are later slices. This is the read side, so a client parses `resultType` from a 2026-07-28 server correctly without waiting for the rest. ## Tests - `resultType` is null when the field is absent, and passes both a known value and an unknown string through unchanged. - `dart test -p chrome,vm -c dart2wasm,dart2js,kernel,exe` passes (219 tests in each of the four configurations). - `dart analyze --fatal-infos` is clean here and in `mcp_examples` resolved against this branch. The diff only adds lines, so existing formatting is untouched. Part of #162.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly declares support for extending the
ResultTypetype so that extensions can extend it with their own extended set of extended values.ResultTypevalues unrecognized by the client are considered invalid protocol responses (fail-closed).This modifies #2322 and #2663.
Motivation and Context
This change makes it clear to SDK maintainers that the
resultTypefield may be extended by extensions. This is particularly relevant for the Tasks extension.In particular, we want to avoid a situation where an extension (like Tasks) requires extending
resultTypebut an SDK has implemented that discriminated union in a way that makes extensions impossible without introducing breaking changes to SDK consumers.How Has This Been Tested?
N/A
Breaking Changes
N/A
Types of changes
Checklist
Additional context