Repository navigation
Bug & Doc Fixes for SEP-2322: MRTR Docs - #2725
Merged
Merged
Conversation
CaitieM20
added
bug
pja-ant
previously approved these changes
May 15, 2026
kurtisvg
previously approved these changes
May 15, 2026
7 of 9 tasks
pja-ant
added a commit
that referenced
this pull request
May 15, 2026
…ward compat
- Remove `@default "complete"` from `Result.resultType` in schema.ts. A
required field has no default; the JSDoc and generated JSON Schema
annotation gave the false impression that omitting it is conformant.
- Add JSDoc explaining the actual model: servers implementing this
protocol version MUST include `resultType`; clients MUST treat an
absent `resultType` from older servers as "complete".
- Fix the TypeScript snippet in basic/index.mdx, which placed
`resultType` as a sibling of `result` in the JSON-RPC envelope. Per
the schema it is a field of `Result` and lives inside `result`.
- Split the contradictory sentence "MUST be included … if not specified
assume complete" into a server requirement and a separate client-side
backward-compatibility rule for results from earlier protocol versions.
- Add the missing verb ("indicates") in the two ResultType definition
bullets, and fix "poly-morphic" -> "polymorphic".
- Regenerate schema.json and schema.mdx.
Note: 19 example JSON files that omit resultType are unchanged by this
PR; #2725 adds resultType to those examples.
…ward compat
- Remove `@default "complete"` from `Result.resultType` in schema.ts. A
required field has no default; the JSDoc and generated JSON Schema
annotation gave the false impression that omitting it is conformant.
- Add JSDoc explaining the actual model: servers implementing this
protocol version MUST include `resultType`; clients MUST treat an
absent `resultType` from older servers as "complete".
- Fix the TypeScript snippet in basic/index.mdx, which placed
`resultType` as a sibling of `result` in the JSON-RPC envelope. Per
the schema it is a field of `Result` and lives inside `result`.
- Split the contradictory sentence "MUST be included … if not specified
assume complete" into a server requirement and a separate client-side
backward-compatibility rule for results from earlier protocol versions.
- Add the missing verb ("indicates") in the two ResultType definition
bullets, and fix "poly-morphic" -> "polymorphic".
- Regenerate schema.json and schema.mdx.
Note: 19 example JSON files that omit resultType are unchanged by this
PR; modelcontextprotocol#2725 adds resultType to those examples.
Contributor
Author
kurtisvg
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixing some minor bugs/docs issues with SEP-2322 MRTR that were missed in the initial pull request:
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context