Skip to content

Conversation

@jspahrsummers
Copy link
Member

This is a breaking change, but one that we agreed was important before release, as it underpins the entire protocol and the client–server initialization cycle.

Resolves #1.

cc @modelcontextprotocol/spec-wg

@jspahrsummers jspahrsummers requested a review from dsp-ant October 7, 2024 15:15
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. We just need to make sure we update the libraries accordingly. We have to be careful with how we roll this out, since Zed currently relies on an integer as a protocol protocol number

@jspahrsummers
Copy link
Member Author

jspahrsummers commented Oct 11, 2024

Probably will just allow number or string in the SDKs' parsing for some time.

@jspahrsummers jspahrsummers merged commit e010392 into main Oct 11, 2024
@jspahrsummers jspahrsummers deleted the justin/version-string branch October 11, 2024 12:46
jspahrsummers added a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Protocol version should be a string, not an int

3 participants