Skip to content

[SEP-1303] Input validation errors as tool execution errors #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsp-ant merged 2 commits into from
Nov 10, 2025
Merged

[SEP-1303] Input validation errors as tool execution errors #1611

dsp-ant merged 2 commits into from
Nov 10, 2025

Conversation

@fredericbarthelet
Copy link
Contributor

@fredericbarthelet fredericbarthelet commented Oct 6, 2025 •
edited
Loading

Fixes #1303

Merging both types of tool execution error invalid arguments and invalid input data under a new category input validation error. This new error category always lies under tool execution error.

Motivation and Context

Ensure model has access to detailed error in order to self-correct.

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@fredericbarthelet fredericbarthelet requested a review from a team as a code owner October 6, 2025 10:19
@fredericbarthelet fredericbarthelet mentioned this pull request Oct 6, 2025
Closed
@fredericbarthelet fredericbarthelet requested a review from a team October 6, 2025 12:32
@dsp-ant dsp-ant added proposal SEP proposal without a sponsor. SEP labels Oct 6, 2025
@pja-ant
Copy link
Contributor

pja-ant commented Oct 16, 2025

We'll need to update change log as well. I'd maybe also suggest adding an example of a validation error.

@fredericbarthelet
Merge invalid arguments and input data errors under a new input valid…
67d8662 
…ation error category in tool execution errors
dsp-ant
dsp-ant requested changes Nov 4, 2025
View reviewed changes
@fredericbarthelet
Copy link
Contributor Author

fredericbarthelet commented Nov 4, 2025

Thanks for your feedback @dsp-ant :)! I implemented your suggestions.

@dsp-ant dsp-ant added accepted SEP accepted by core maintainers, but still requires final wording and reference implementation. and removed proposal SEP proposal without a sponsor. labels Nov 10, 2025
dsp-ant
dsp-ant approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dsp-ant dsp-ant merged commit f06bcf5 into modelcontextprotocol:main Nov 10, 2025
2 checks passed
Copilot AI mentioned this pull request Nov 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsp-ant dsp-ant dsp-ant approved these changes

Assignees

No one assigned

Labels

accepted SEP accepted by core maintainers, but still requires final wording and reference implementation. SEP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SEP-1303: Input Validation Errors as Tool Execution Errors

3 participants

@fredericbarthelet @pja-ant @dsp-ant