Change Icon.sizes from string to string array #1531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp-ant
force-pushed
the
icon-sizes-array
branch
2 times, most recently
from
0beaaf5 to
9524bae
Compare
dsp-ant
force-pushed
the
icon-sizes-array
branch
from
9524bae to
82a73a1
Compare
Introduces standardized tiering system for MCP SDKs based on: - Specification compliance - Maintenance quality - Update frequency Defines three tiers to help developers choose appropriate SDKs and provide clear improvement pathways for maintainers.
The Icon.sizes field was previously defined as a space-separated string (e.g., "48x48 96x96"), which was ambiguous and error-prone to parse. Changed to string[] format (e.g., ["48x48", "96x96"]) for clarity and consistency. Each size is now a discrete array element, making it easier to iterate over and validate individual size specifications. This maintains compatibility with the "any" keyword for scalable formats while providing a cleaner, more structured representation. Co-Authored-By: Claude <[email protected]>
dsp-ant
force-pushed
the
icon-sizes-array
branch
from
82a73a1 to
b3de157
Compare
pja-ant
approved these changes
Sep 25, 2025
bhosmer-ant
reviewed
Sep 26, 2025
Contributor
bhosmer-ant
left a comment
bhosmer-ant
left a comment
There was a problem hiding this comment.
No objections, but this is a breaking change, right?
Contributor
Icons are introduced in the upcoming spec, so it's not breaking any existing non-draft spec. |
dend
approved these changes
Sep 27, 2025
localden
approved these changes
Sep 27, 2025
Contributor
|
modelcontextprotocol/typescript-sdk#947 is updated for TypeScript side. I'll update the python impl to reflect this. |
pja-ant
added a commit
to modelcontextprotocol/python-sdk
that referenced
this pull request
Sep 29, 2025
Changes Icon.sizes from a space-separated string to a list of strings, aligning with spec changes in modelcontextprotocol/modelcontextprotocol#1531. This provides clearer, more consistent size specifications that are easier to iterate over and validate. Updated all examples and tests to use the new list format.
9 tasks
22 tasks
honsunrise
pushed a commit
to honsunrise/rust-sdk
that referenced
this pull request
Oct 9, 2025
9 tasks
honsunrise
added a commit
to honsunrise/rust-sdk
that referenced
this pull request
Oct 9, 2025
4t145
pushed a commit
to modelcontextprotocol/rust-sdk
that referenced
this pull request
Oct 10, 2025
This was referenced Oct 11, 2025
findleyr
pushed a commit
to modelcontextprotocol/go-sdk
that referenced
this pull request
Nov 12, 2025
mcp/protocol: Implement SEP-973 - Define Icon structure, which includes source, mimeType and sizes. - sizes is any array of strings. refer modelcontextprotocol/modelcontextprotocol#1531 - Support setting websiteUrl, icons for mcp.Implementation - Support setting icons for mcp.Prompt - Support setting icons for mcp.Tool - Support setting icons for mcp.Resource Fixes #552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Icon.sizes field was previously defined as a space-separated string (e.g., "48x48 96x96"), which was ambiguous and error-prone to parse.
Changed to string[] format (e.g., ["48x48", "96x96"]) for clarity and consistency. Each size is now a discrete array element, making it easier to iterate over and validate individual size specifications.
This maintains compatibility with the "any" keyword for scalable formats while providing a cleaner, more structured representation.